Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: don't import algebra in Data.Multiset.Basic #19775

Closed
wants to merge 1 commit into from

Conversation

@YaelDillies YaelDillies added WIP Work in progress t-data Data (lists, quotients, numbers, etc) labels Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

PR summary 6e707f4d64

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Multiset.Basic 371 358 -13 (-3.50%)
Import changes for all files
Files Import difference
There are 3846 files with changed transitive imports taking up over 167185 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ add_assoc
+ add_comm
+ add_le_add_iff_left
+ add_le_add_iff_right
+ add_left_inj
+ add_right_inj
+ add_sub_assoc
+ add_sub_cancel
+ add_sub_cancel_right
+ add_zero
+ eq_sub_of_add_eq
+ instAddCancelCommMonoid
+ instAddLeftMono
+ instAddLeftReflectLE
+ instance : OrderedSub (Multiset α) where tsub_le_iff_right _n _m _k := Multiset.sub_le_iff_le_add
+ instance : Union (Multiset α)
+ le_add_sub
+ le_sub_add
+ sub_add_cancel
+ sub_add_eq_sub_sub
+ sub_le_iff_le_add'
+ sub_le_sub_right
+ zero_add
+ ⟨le_of_add_le_add_left,
+ ⟨le_of_add_le_add_right,
- instAddCommMonoid
- instance : AddLeftMono (Multiset α)
- instance : AddLeftReflectLE (Multiset α)
- instance : OrderedSub (Multiset α)
- instance : Union (Multiset α) := ⟨union⟩

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.01)
Current number Change Type
204 2 disabled simpNF lints

Current commit 6e707f4d64
Reference commit fceef13c1e

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 7, 2024
@YaelDillies YaelDillies removed the WIP Work in progress label Dec 7, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 9, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 9, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 9, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 10, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 18, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 23, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 6, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 6, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 6, 2025
@YaelDillies YaelDillies requested a review from Vierkantor January 6, 2025 18:03
@kim-em
Copy link
Contributor

kim-em commented Jan 6, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 6, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: don't import algebra in Data.Multiset.Basic [Merged by Bors] - chore: don't import algebra in Data.Multiset.Basic Jan 7, 2025
@mathlib-bors mathlib-bors bot closed this Jan 7, 2025
@mathlib-bors mathlib-bors bot deleted the multiset_no_algebra branch January 7, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants