Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove fix-comments.py #15242

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jul 28, 2024

This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.


Helps with #14539. PR #15222 (in progress) runs that script on all of mathlib, but is based on the above tag - removing it on master does not interfere with this.

Open in Gitpod

This script has served its purpose during the port;
now that all align information has been removed from mathlib,
it is not useful for other projects either.

Projects which wish to use such functionality should check out the
v3-eol tag and use the script from that commit.
@grunweg grunweg requested a review from kim-em July 28, 2024 21:12
Copy link

PR summary 41108bb85e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- finish_comment():
- mktree(path,
- process_backticked_names(s):
- replace_names(s):

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for `script/declarations_diff.sh` contains some details about this script.

@j-loreaux
Copy link
Collaborator

I agree, now that the #aligns are actually removed, this has no use.

maintainer merge

Copy link

github-actions bot commented Aug 1, 2024

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@bryangingechen
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 4, 2024
This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove fix-comments.py [Merged by Bors] - chore: remove fix-comments.py Aug 4, 2024
@mathlib-bors mathlib-bors bot closed this Aug 4, 2024
@mathlib-bors mathlib-bors bot deleted the MR-remove-fixcomments branch August 4, 2024 13:29
grunweg added a commit that referenced this pull request Aug 4, 2024
This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
This script has served its purpose during the port; now that all align information has been removed from mathlib, it is not useful for other projects either.

Projects which wish to use such functionality should check out the v3-eol tag and use the script from that commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants