-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
David dev #10
Open
frobnitzem
wants to merge
17
commits into
main
Choose a base branch
from
david-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
David dev #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed psana2h5 to xtc2h5 - additional docs - removed step_NN from h5 top-level group - added step_value back to stepinfo (h5 attributes)
frobnitzem
force-pushed
the
david-dev
branch
from
November 14, 2024 05:03
f6d161c
to
0f2bde5
Compare
Batch.attr['events'] now counts the batch size, and attrs are read/written (still need test coverage). Documentation is improved.
frobnitzem
force-pushed
the
david-dev
branch
from
November 14, 2024 05:20
0f2bde5
to
f55dd55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in computing "addresses" for mrco_hsd TOF-s, split h5-s by experiment "step", and added h5 file format documentation.