Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement AI Client #36
refactor: implement AI Client #36
Changes from 26 commits
f25033c
ccdbada
8049816
8c34ad5
43aa7aa
25142ac
0d58582
37f395d
c74c9e3
7b0e446
44956bc
42a6b05
59dc7e7
949c635
e7d8fc2
36152b8
96b8fb0
3abb9e5
bdfe78a
dc4fe3d
796b85f
fa56649
aa1310a
b5a354d
e6e4ee7
d9b343b
6ec3f94
8c18ca5
ce64ccf
c513a2f
dd3492d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some duplication here. This file is meant to contain classes that can be directly JSON deserialized, but this doesn't lend itself to the user-facing types. For instance, these fields have
get; set;
and I don't want that to be accessible to users. So, I deserialize these and then convert them intoLdAiConfig
.I can't make these internal (deserialization seems to fail) and I can't use
init;
(we still support .net 4.6.2.)I may be missing a more idiomatic way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to tell it to use a parameterized constructor
JsonContructor
which allows creating immutable types, but you would have to have a full parameterized constructor for the records (because noinit
).