-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement AI Client #36
Conversation
d7e4c8f
to
c00ae79
Compare
c00ae79
to
42a6b05
Compare
@@ -0,0 +1,89 @@ | |||
using System.Collections.Generic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some duplication here. This file is meant to contain classes that can be directly JSON deserialized, but this doesn't lend itself to the user-facing types. For instance, these fields have get; set;
and I don't want that to be accessible to users. So, I deserialize these and then convert them into LdAiConfig
.
I can't make these internal (deserialization seems to fail) and I can't use init;
(we still support .net 4.6.2.)
I may be missing a more idiomatic way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to tell it to use a parameterized constructor JsonContructor
which allows creating immutable types, but you would have to have a full parameterized constructor for the records (because no init
).
cf0d7de
to
6ec3f94
Compare
8d961ca
to
5c141ab
Compare
5c141ab
to
c513a2f
Compare
Updated to pass Note: if there are cycles in the |
This implements the guts of the AI client, including fetching Model configuration, interpolation, and tests.