Quirk: no-operation-state #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good, but also think this option should be a quirk and not a full-fledged separate option. |
0pq76r
force-pushed
the
feature/operation-state-quirk
branch
from
a8e045f to
14ab66f
Compare
simo5
approved these changes
Dec 6, 2023
0pq76r
changed the title
0pq76r
force-pushed
the
feature/operation-state-quirk
branch
4 times, most recently
from
6d65ee0 to
bd18833
Compare
Configuration property to indicate whether the PKCS11 provider supports getting/setting the operation state. If it is not supported, no attempts will be made to duplicate the context. Signed-off-by: Florian Wernli <[email protected]>
0pq76r
force-pushed
the
feature/operation-state-quirk
branch
2 times, most recently
from
de01045 to
2ae7363
Compare
Test for quirk no-operation-state. Signed-off-by: Florian Wernli <[email protected]>
0pq76r
force-pushed
the
feature/operation-state-quirk
branch
from
2ae7363 to
2f260f4
Compare
|
Thanks, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration property to indicate whether the PKCS11 provider supports getting/setting the operation state. If it is not supported, no attempts will be made to duplicate the context.
I already mentioned it in the discussion (#320) that the current approach leaves traces in the SSL error stack.
Please let me know what you think of this change.
(Tests will follow)