-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend operation state quirk to cover all operation state operations. #327
Comments
@sahanaprasad07 can you pick this one up in the future? |
Hi @simo5 , which other operation state do you mean here? GetOperationState is only called in signature.c and digests.c. Operate state quirk seems to be covered in both these places already. |
I think the switch should be checked within the GetOperationState interface function, instead of checking for it in all the places where it is called. So it is a matter of special casing this function like I did here: pkcs11-provider/src/interface.c Line 455 in e2abc4a
The only difference is that we completely replace the auto-generated "Get/SetOperationState" functions from interface.pre instead of just adding a special case. |
Or maybe we find a generic way to block any function call and add the same code to all, it could be done with a bitfield store on the provider context and then have a generic check in the autogenerated functions. |
PR #324 introduced the ability to set a configuration quirk so that trying to save the state is not even attempted.
This should be extended to all uses of the operation state function.
Ideally by checking for the quirk within the body of the operation state wrapper itself.
The text was updated successfully, but these errors were encountered: