This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
♻️ Rename RecordMeta to Registry and refactor __repr__(cls)
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
RecordMeta to Registry and refactor repr
falexwolf
commented
Aug 3, 2024
| @@ -16,7 +16,7 @@ def test_registry__repr__param(setup_instance): | |||
| param = ln.Param | |||
| expected_repr = textwrap.dedent("""\ | |||
| Param | |||
| Basic fields | |||
| Simple fields | |||
There was a problem hiding this comment.
@Zethson @fredericenard for consistency across out "django field modeling" codebase
I fear there might be lot's of duplication across what Lukas did here, and what Fred did before in the hub.
But given we somewhat have a tradition of writing these helper classes for SA & Django ORM already for years (back then also @sunnyosun wrote some of this code), we at least seem consistent in that. :D
falexwolf
changed the title
RecordMeta to Registry and refactor reprRecordMeta to Registry and refactor __repr__(cls)
This was referenced Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
__repr__(cls)to enable documenting registries consistently:The class method was previously contributed by @Zethson: