🚚 Rename RecordMeta to Registry
#1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
RecordMeta to Registry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
- Coverage 92.19% 92.16% -0.03%
==========================================
Files 51 51
Lines 5598 5616 +18
==========================================
+ Hits 5161 5176 +15
- Misses 437 440 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stresses that every
Recordcomes with aRegistryin form of its metaclass.As the metaclass maps 1:1 on the corresponding SQL table, this is also what we intuitively understand as "registry".
Hence: Sub-classing
Recorddefines a new registry while instantiatingRecorddefines a new record.RecordMetatoRegistryand refactor__repr__(cls)lnschema-core#414RecordMetatoRegistrylamindb-setup#814