Allow laminas/laminas-validator 3.0 #83
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the preparation PR for the release of https://github.com/laminas/laminas-validator/tree/3.0.x
As far as i see there aren't any BC breaks here in this package because there is only this usage of the Hostname Validator:
All of these options and methods are still available in the unreleased 3.0.x branch
The important change would be this signature change
https://github.com/laminas/laminas-validator/blob/3.0.x/src/Hostname.php#L1814
But in the current implementation of laminas-http the
$host
variable isstring
and i think this should be fine