Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.4 #84

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Allow PHP 8.4 #84

merged 9 commits into from
Oct 18, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Aug 3, 2024

No description provided.

Signed-off-by: Stéphane Demonchaux <[email protected]>
@fezfez
Copy link
Contributor Author

fezfez commented Aug 3, 2024

@gsteel ci seem to be broken.. :/

@gsteel
Copy link
Member

gsteel commented Aug 3, 2024

CI looks fine. Tests are broken though. The error looks consistent. Possibly something changed in libcurl. 🤷‍♂️

@fezfez
Copy link
Contributor Author

fezfez commented Aug 4, 2024

CI looks fine. Tests are broken though. The error looks consistent. Possibly something changed in libcurl. 🤷‍♂️

The test even fail in #83 IMO it's not related to this pr

Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fezfez - You help is much appreciated :)

@gsteel gsteel self-assigned this Oct 18, 2024
@gsteel gsteel added this to the 2.20.0 milestone Oct 18, 2024
@gsteel gsteel merged commit a66bfb6 into laminas:2.20.x Oct 18, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants