[Feature] Added support for force option when sending flow mods
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parametrized reraise_conn on _install_flows method
Extracted new_flow_dict on utils.py
Added TODO
Added TODO for err handling
ajoaoff
approved these changes
Nov 26, 2021
|
Appreciated the reviews, guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Description of the change
forceoption when sending flow modsOnce this change lands, clients can decide reliably if they want to
forcethe flow mode to be sent later on (via consistency check) in case any switch connection errors happened as the flows were being installed. So, it's up to each client to decide if the client wants the flows to be either forced or not, for example, ifmef_elinewants the flows being installed or fail immediately in case a switch isn't connected, then setforce: false, for applications that don't care when the flow should be installed, and there's no other potential paths that the client could make of use then settingforce: truewould be handy.Notice that errors could still happen even when
force: trueis set (for instance, imagine a client sends a flow mod with force true, the switch isn't available and then the installation has an unsupported instruction for that switch), the rest of error propagation, and more tests for this, will be covered on issue #2.