Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image name parsing #342

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix image name parsing #342

merged 4 commits into from
Nov 20, 2024

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Nov 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • use proper image name parsing
    • now Warden will stop operation early when non-parsable image name was provided (no image name, broken SHA256)
  • fail when no tag or hash was provided explicitly
  • require image name to explicitly contain domain, do not default docker.io

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
@halamix2 halamix2 marked this pull request as ready for review November 20, 2024 10:07
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
anoipm
anoipm previously approved these changes Nov 20, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 20, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
@halamix2 halamix2 requested a review from anoipm November 20, 2024 12:26
@halamix2 halamix2 merged commit f8900ef into kyma-project:main Nov 20, 2024
14 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@halamix2 halamix2 deleted the better-image-parsing branch November 20, 2024 12:37
halamix2 added a commit to halamix2/warden that referenced this pull request Nov 20, 2024
@halamix2
Fix image name parsing (kyma-project#342)
345e04b 
* Fix image name parsing

* simplify validation

* test

* Adjust test to provide a valid image name
@halamix2 halamix2 mentioned this pull request Nov 20, 2024
Merged
halamix2 added a commit that referenced this pull request Nov 20, 2024
@halamix2
Fix image name parsing (#342) (#343)
453ae3c 
* Fix image name parsing

* simplify validation

* test

* Adjust test to provide a valid image name
halamix2 added a commit to halamix2/warden that referenced this pull request Nov 21, 2024
@halamix2
Fix image name parsing (kyma-project#342)
8e26fc9 
* Fix image name parsing

* simplify validation

* test

* Adjust test to provide a valid image name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@anoipm anoipm

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @anoipm @kyma-bot