Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name parsing (#342) #343

Merged

Conversation

halamix2
Copy link
Member

  • Fix image name parsing

  • simplify validation

  • test

  • Adjust test to provide a valid image name

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

* Fix image name parsing

* simplify validation

* test

* Adjust test to provide a valid image name
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@halamix2 halamix2 merged commit 453ae3c into kyma-project:release-0.14 Nov 20, 2024
8 checks passed
@halamix2 halamix2 deleted the r014-better-image-parsing branch November 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants