wg,arch: fix some errors in label setup #3762
Conversation
kubevirt-bot
added
dco-signoff: yes
|
/override pull-project-infra-prow-deploy-test since the deploy test is not relevant to the changes. |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dhiller
force-pushed
the
fix-errors-wrt-new-wgs
branch
from
0e52d86
to
cc6a3e3
Compare
|
FYI pinging some maintainers to get attention: @vladikr @fabiand Also pinging @brianmcarey for awareness :) |
|
The labels all look good to me but I'd rather the adding of a member was its own PR. There are conditions of the member template that the member agrees to (CoC, 2fa, etc) that I don't think can be affirmed by a third party. WDYT? |
|
@aburdenthehand I created this PR: #3767 |
Add three new labels, two for the working groups around arch, and another one for the soon to be forming code-quality working group. Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
fix-errors-wrt-new-wgs
branch
from
cc6a3e3
to
a2c2e48
Compare
|
@aburdenthehand I also remove the commit that adds @cfilleke to the org from this PR |
dhiller
changed the title
|
/cc @brianmcarey |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@dhiller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR fixes some issues with regard to current wg-arch declarations, since the labels wrt wg-arch don't exist yet 1. This PR adds them.
/cc @aburdenthehand
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
The improvements around the sigs.yaml validation made those issues visible 1.
Remaining issues will be corrected inside the validation PR kubevirt/community#350.