sigs,generate: improve validation, update sig-list generation

[dhiller]

What this PR does / why we need it:

This PR improves the validation of sigs.yaml - it checks entries with

• existing directories (sig/wg)
• existing labels (using project-infra labels.yaml)
• whether github accounts are actually org members (using project-infra orgs.yaml)

If --dry-run flag is false it will overwrite the orgs.yaml with the result, where each entry that failed to check will have been removed.

Also it adds to make target generate the run of the validation with --dry-run=false which will lead to a modified sigs.yaml which in turn will update the sig-list.md with corrected entries, which will then fail the check whether all changes have been committed.

This effectively will automate the validation whether all changes are correct and have been applied to generated markdown.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #321

Special notes for your reviewer:

[kubevirt-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[dhiller]

/test ?

[kubevirt-bot]

@dhiller: The following commands are available to trigger required jobs:

• /test pull-community-make-generate
• /test pull-community-validate-sigs-yaml

Use /test all to run the following jobs that were automatically triggered:

• pull-community-make-generate

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dhiller]

/rehearse ?

[dhiller]

/test pull-community-make-generate

[dhiller]

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-make-generate a519c22 link true /test pull-community-make-generate

Error makes sense, since we need to modify the presubmit to add the project-infra directory, so that the binary can access it.

[dhiller]

/hold

since this PR requires an update of pull-community-make-generate - it needs the project-infra checkout to access labels.yaml and orgs.yaml as described in PR description.

[dhiller]

pull-community-make-generate

Will be fixed by kubevirt/project-infra#3761

[dhiller]

/test pull-community-make-generate

[dhiller]

/unhold

should be ready to go in now.

[dhiller]

/hold

to wait for kubevirt/project-infra#3762 to go in

[dhiller]

kubevirt/project-infra#3762 is required to go in before this can work - however we should make this land soon, since it ensures that no more errors wrt labels and github handles sneak in.

FYI @vladikr @aburdenthehand

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from aburdenthehand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhiller]

/test pull-community-make-generate

[dhiller]

/test pull-community-make-generate

[kubevirt-bot]

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-community-validate-sigs-yaml	5ab99d9	link	true	/test pull-community-validate-sigs-yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dhiller]

As a followup we should remove the pull-community-validate-sigs-yaml job, since the call is added here anyway

kubevirt/project-infra#3779 will remove the presubmit

[dhiller]

/uncc @cwilkers
/cc @vladikr

Adding Vladik for attention around sigs.yaml validation (hope you find the time :) )

[aburdenthehand]

/lgtm
Just re-adding the label from before :)

[dhiller]

/lgtm Just re-adding the label from before :)

@aburdenthehand sorry, but could you do me the favor of taking a look again - had to rebase due to changes for observability.

[aburdenthehand]

/lgtm