Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ai-face config definition #4

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix ai-face config definition #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
############

build-plugins: ## Builds all plugins for all defined platforms
goreleaser build -f .goreleaser.plugin.yaml --rm-dist --snapshot
goreleaser build -f .goreleaser.plugin.yaml --clean --snapshot
.PHONY: build-plugins

build-plugins-single: ## Builds specified plugins in binary format only for current GOOS and GOARCH.
go run github.com/kubeshop/botkube/hack/target/build-plugins -plugin-targets=$(PLUGIN_TARGETS) -output-mode=binary -single-platform
.PHONY: build-plugins-single

build-plugins-archives: ## Builds all plugins for all defined platforms in form of archives
goreleaser release -f .goreleaser.plugin.yaml --rm-dist --snapshot
goreleaser release -f .goreleaser.plugin.yaml --clean --snapshot
.PHONY: build-plugins

##############
Expand Down
7 changes: 4 additions & 3 deletions cmd/executor/ai-face/config_schema.json
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed that the JSON schema will be the same both for brain and face. I understand why it is needed but looks like merging the AI plugin (face+brain) will be a bit more complicated on Cloud Backend side 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this schema can be treated as the technical one, actually we won't have any input params for the user to select. This will be done either on the UI or backend side. It will be kinda hacky but I don't think that it will complicate it 🤔 Let's see 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's not user-facing then it's all good 👍 Because if we wanted to display it to users then we'd need to merge both schemas etc.

Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"title": "Echo",
"description": "Echo is an example Botkube executor plugin used during e2e tests. It's not meant for production usage.",
"title": "AI Face",
"description": "Proxies incoming prompts into AI engine a.k.a brain that responds with analysis.",
"type": "object",
"properties": {
"aiBrainSourceName": {
"type": "string",
"default": "ai-brain"
"default": "ai-brain",
"title": "AI Brain configuration source name. It is used to trigger AI brain using incoming webhook payload."
}
},
"required": []
Expand Down
2 changes: 1 addition & 1 deletion cmd/executor/ai-face/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const (

// Config holds executor configuration.
type Config struct {
AIBrainSourceName string `json:"aiBrainSourceName"`
AIBrainSourceName string `yaml:"aiBrainSourceName"`
Log config.Logger `yaml:"log"`
}

Expand Down
Loading