Fix ai-face config definition #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
fix-exec-cfg
branch
from
24ca517 to
e5d3528
Compare
pkosiec
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I thought we agreed that the JSON schema will be the same both for brain and face. I understand why it is needed but looks like merging the AI plugin (face+brain) will be a bit more complicated on Cloud Backend side 🤔
There was a problem hiding this comment.
this schema can be treated as the technical one, actually we won't have any input params for the user to select. This will be done either on the UI or backend side. It will be kinda hacky but I don't think that it will complicate it 🤔 Let's see 👍
There was a problem hiding this comment.
If that's not user-facing then it's all good 👍 Because if we wanted to display it to users then we'd need to merge both schemas etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fix https://github.com/kubeshop/botkube-cloud/issues/890