Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use K8s v1.29.0 in e2e test #828
Use K8s v1.29.0 in e2e test #828
Changes from all commits
65b9757
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor question @DanielXiao :
Will it have any side effects if we only support v1beta1, is it safe to remove the v1alpha3 and v1alpha4 support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are only installing one version of Cluster API which is v1.6.1. Dropping v1.5, v1.4, ... doesn't change anything.
The apiVersions supported will be the one supported by Cluster API v1.6.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional context. In core CAPI and in CAPV we have tests that test the following:
The idea is to verify if we can upgrade from a set of CAPI & CAPV versions to another one. This is the reason why we have to define multiple CAPI & CAPV versions in this config file.
Here in CPI you only want to create a workload cluster with specific versions of CAPI & CAPV. There is no upgrade test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks @sbueringer !