Use K8s v1.29.0 in e2e test #828

DanielXiao · 2024-01-19T09:10:00Z

What this PR does / why we need it:
Pretest Job pull-cloud-provider-vsphere-e2e-test runs against K8s v1.23.5 Clusters which is already out of support in Cluster-API.

This patch bumps dependent CAPI to 1.6.1 and CAPV to 1.9.0 to deploy v1.29.0 Clusters. It also adds a makefile target to run test locally with any development images manually pushed to a registry. This is helpful for local development because you don't have to create a PR for pushing the image to gcr.io/cloud-provider-vsphere/cpi/pr/manager.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #780

Special notes for your reviewer:

Release note:

DanielXiao · 2024-01-19T09:11:49Z

/ok-to-test

test/e2e/config/vsphere-ci.yaml

DanielXiao · 2024-01-19T11:31:41Z

/test pull-cloud-provider-vsphere-e2e-test

XudongLiuHarold

generally lgtm, some minor questions.

/lgtm

test/e2e/config/vsphere-ci.yaml

test/e2e/Makefile

test/e2e/go.mod

test/e2e/config/vsphere-ci.yaml

chrischdi

We could propably also cleanup the variables part, but I think its okay to keep it comparable.

test/e2e/config/vsphere-ci.yaml

test/e2e/e2e_suite_test.go

sbueringer · 2024-01-22T17:04:36Z

I think with the changes suggested this should be a good step to test with latest stable CAPI & CAPV releases and Kubernetes 1.29.0.

I think it would be good if we talk ~ 1 month before the Kubernetes 1.30 release to see if we want to start bumping towards 1.30 (at this point we should also already know with CAPI & CAPV versions are needed to create 1.30 clusters).

sbueringer · 2024-01-22T17:09:37Z

Something worth highlighting. The sigs.k8s.io/controller-runtime dependency in the top-level go.mod file could be a major showstopper for quick 1.30 support.

Example:

Let's assume k8s.io/* 0.29 and 0.30 dependencies are not compile-compatible
Then you have to wait until controller-runtime 0.17 is released before you can bump to k8s.io/cloud-provider 0.30
The last time it took ~ 4 weeks from the Kubernetes 1.29 to the controller-runtime 0.16 release (which used 0.29 k8s.io dependencies)
We can't really speed up the controller-runtime release by much as it depends on a lot of other people

=> Given that, I would recommend to get rid of the controller-runtime dependency in the top-level go.mod file

(cc @DanielXiao @lubronzhan)

Pretest Job pull-cloud-provider-vsphere-e2e-test runs against K8s v1.23.5 Clusters which are already out of support in Cluster-API. This patch bumps dependent CAPI to 1.6.1 and CAPV to 1.9.0 to deploy v1.29.0 Clusters. It also adds a makefile target to run test locally with any development images manually pushed to a registry. This is helpful for local development because you don't have to create a PR for pushing the image to gcr.io/cloud-provider-vsphere/cpi/pr/manager. This patch also remove variable INIT_WITH_KUBERNETES_VERSION. KUBERNETES_VERSION will be used for both bootstrap and workload cluster version.

test/e2e/config/vsphere-ci.yaml

XudongLiuHarold

The PR looks great, just one minor question

/lgtm

XudongLiuHarold · 2024-01-23T10:34:00Z

test/e2e/config/vsphere-ci.yaml

-          new: "imagePullPolicy: IfNotPresent"
-      files:
-      - sourcePath: "../data/shared/metadata.yaml"
+- name: cluster-api


Just one minor question @DanielXiao :

Will it have any side effects if we only support v1beta1, is it safe to remove the v1alpha3 and v1alpha4 support?

You are only installing one version of Cluster API which is v1.6.1. Dropping v1.5, v1.4, ... doesn't change anything.

The apiVersions supported will be the one supported by Cluster API v1.6.1

Some additional context. In core CAPI and in CAPV we have tests that test the following:

install old versions of CAPI & CAPV

create a workload cluster

upgrade to newer versions of CAPI & CAPV

modify the workload cluster

The idea is to verify if we can upgrade from a set of CAPI & CAPV versions to another one. This is the reason why we have to define multiple CAPI & CAPV versions in this config file.

Here in CPI you only want to create a workload cluster with specific versions of CAPI & CAPV. There is no upgrade test.

Gotcha, thanks @sbueringer !

sbueringer · 2024-01-23T10:42:40Z

Thx!

/lgtm

XudongLiuHarold

/approve

k8s-ci-robot · 2024-01-23T10:49:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanielXiao, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [XudongLiuHarold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

DanielXiao · 2024-01-24T06:06:07Z

/cherry-pick release-1.29

k8s-infra-cherrypick-robot · 2024-01-24T06:06:45Z

@DanielXiao: new pull request created: #839

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2024

k8s-ci-robot requested review from andrewsykim and imkin January 19, 2024 09:10

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 19, 2024

DanielXiao commented Jan 19, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

XudongLiuHarold reviewed Jan 22, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

test/e2e/Makefile Outdated Show resolved Hide resolved

k8s-ci-robot assigned XudongLiuHarold Jan 22, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024

DanielXiao commented Jan 22, 2024

View reviewed changes

test/e2e/Makefile Show resolved Hide resolved

DanielXiao commented Jan 22, 2024

View reviewed changes

test/e2e/go.mod Show resolved Hide resolved

chrischdi reviewed Jan 22, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

chrischdi reviewed Jan 22, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

sbueringer reviewed Jan 22, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

test/e2e/config/vsphere-ci.yaml Outdated Show resolved Hide resolved

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

sbueringer reviewed Jan 22, 2024

View reviewed changes

test/e2e/e2e_suite_test.go Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024

DanielXiao force-pushed the bump-e2e-k8s branch from f5c8abc to 65b9757 Compare January 23, 2024 04:31

chrischdi reviewed Jan 23, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

chrischdi reviewed Jan 23, 2024

View reviewed changes

test/e2e/config/vsphere-ci.yaml Show resolved Hide resolved

XudongLiuHarold reviewed Jan 23, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024

k8s-ci-robot assigned sbueringer Jan 23, 2024

XudongLiuHarold approved these changes Jan 23, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024

k8s-ci-robot merged commit 5ea4d96 into kubernetes:master Jan 23, 2024
15 checks passed

k8s-infra-cherrypick-robot mentioned this pull request Jan 24, 2024

[release-1.29] Use K8s v1.29.0 in e2e test #839

Merged

DanielXiao deleted the bump-e2e-k8s branch January 24, 2024 06:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use K8s v1.29.0 in e2e test #828

Use K8s v1.29.0 in e2e test #828

DanielXiao commented Jan 19, 2024

DanielXiao commented Jan 19, 2024

DanielXiao commented Jan 19, 2024

XudongLiuHarold left a comment

chrischdi left a comment

sbueringer commented Jan 22, 2024 •

edited

Loading

sbueringer commented Jan 22, 2024 •

edited

Loading

XudongLiuHarold left a comment •

edited

Loading

XudongLiuHarold Jan 23, 2024 •

edited

Loading

sbueringer Jan 23, 2024

sbueringer Jan 23, 2024 •

edited

Loading

XudongLiuHarold Jan 23, 2024

sbueringer commented Jan 23, 2024

XudongLiuHarold left a comment

k8s-ci-robot commented Jan 23, 2024

DanielXiao commented Jan 24, 2024

k8s-infra-cherrypick-robot commented Jan 24, 2024

Use K8s v1.29.0 in e2e test #828

Use K8s v1.29.0 in e2e test #828

Conversation

DanielXiao commented Jan 19, 2024

DanielXiao commented Jan 19, 2024

DanielXiao commented Jan 19, 2024

XudongLiuHarold left a comment

Choose a reason for hiding this comment

chrischdi left a comment

Choose a reason for hiding this comment

sbueringer commented Jan 22, 2024 • edited Loading

sbueringer commented Jan 22, 2024 • edited Loading

XudongLiuHarold left a comment • edited Loading

Choose a reason for hiding this comment

XudongLiuHarold Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

sbueringer Jan 23, 2024

Choose a reason for hiding this comment

sbueringer Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

XudongLiuHarold Jan 23, 2024

Choose a reason for hiding this comment

sbueringer commented Jan 23, 2024

XudongLiuHarold left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 23, 2024

DanielXiao commented Jan 24, 2024

k8s-infra-cherrypick-robot commented Jan 24, 2024

sbueringer commented Jan 22, 2024 •

edited

Loading

sbueringer commented Jan 22, 2024 •

edited

Loading

XudongLiuHarold left a comment •

edited

Loading

XudongLiuHarold Jan 23, 2024 •

edited

Loading

sbueringer Jan 23, 2024 •

edited

Loading