Support other flavour of CRI

[CiraciNicolo]

Change description

This PR implements support for different CRI implementations, instead of the default containerd. At this moment the only other CRI implementation supported is CRI-O. By default containerd is still the default CRI, to start using CRI-O references the packer configuration called "qemu-ubuntu-2204-crio.json".

Currently the only operating systems supported are debian based and centos based. It should also work on rhel but not tested.

The implementation can be done following this steps:

• create an ansible role for your CRI flavour
• implement default packer variables
• create builder target and makefile target

Both ansible role and default values should be called as your flavour, in this way you can set the cri_flavour build variable and all tasks/var should be included.

Be also careful to correctly default the variables in images/capi/packer/config/ansible-args.json and implement the goss specs.

Related issues

No issues are addressed by this PR

This PR also includes the following fixes:

• Fix incorrect boolean evalutation for GVisor installation if enabled. Be careful that this fixes could change the expected behaviour if you are leveraging Gvisor

Additional context

[k8s-ci-robot]

Hi @CiraciNicolo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mboersma]

Great stuff--this is a lot of work!

I did a quick review and just had some documentation suggestions. Also two general comments:

• please update the copyright year to 2024 in new files
• please add a final newline to all files

[mboersma]

/ok-to-test

[jsturtevant]

Great work! A few comments on the public API for cri specific fields

Do we have a way to test this in CI?

[jsturtevant]

thought: would be it be easier if this was just cri_version? We would need to keep containerd_version around for a release but then could remove it in a future release?

[jsturtevant]

Same with crio_cri_socket, should this be cri_socket? And later we can remove the containerd_cri_socket from the public api?

[CiraciNicolo]

Thanks! I will check all your reports tomorrow. Great idea about removing specific variables for containerd, I was afraid doing that would introduce some issues.

[jsturtevant]

Great idea about removing specific variables for containerd, I was afraid doing that would introduce some issues.

To be clear we should keep the variables for a release or two and mark them depreciated, otherwise it would could some hickups for folks I think.

[CiraciNicolo]

Yes, I was thinking the same thing. Will work on that, I'm a little bit rusty on packer and need to understand how can we manage if-not-defined-then for user variables. Will work on that this week

[CiraciNicolo]

Hi, since I messed up and worked on main instead of a branch I'm gonna close this PR and rework my commits into a dedicated branch. We can continue discuss there! Hope this is ok.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CiraciNicolo]

Hi! I cherry picked the commits to another branch, this is more cleaner. Please, refer to #1442.

Sorry for the incorrect handling on the main branch.