Skip to content

Commit

Permalink
feat(crio): Fix documentation and formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
CiraciNicolo committed Mar 29, 2024
1 parent 6959f3f commit e7edde7
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions docs/book/src/capi/cri/cri.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Container Runtime

The image-builder project support different implementation, referred as flavour in this book, as CRI. The preferred one is containerd but cri-o is supported for some kind of platforms - depending on cri-o supported operating systems. By default the built-in CNI provided by CRI-O is disabled, to enabled use the following variable:
The image-builder project supports different implementations of CRI, referred to as flavours in this book, as CRI. The preferred option is containerd, but CRI-O is supported for some kind of platforms - depending on cri-o supported operating systems. By default, the built-in CNI provided by CRI-O is disabled. To enable use the following variable:

```json
{
Expand All @@ -10,7 +10,7 @@ The image-builder project support different implementation, referred as flavour

## crictl

When cri-o is preferred, crictl is not provided with the package. This means you need to install it using the http source type:
When CRI-O is specified, `crictl` is not provided with the installation package. You need to install it using the `http` source type:

```json
{
Expand All @@ -20,16 +20,16 @@ When cri-o is preferred, crictl is not provided with the package. This means you

## Running sandboxed containers using gVisor

As of now gVisor support is implemented but broken - [gvisor/issue/3283](https://github.com/google/gvisor/issues/3283). Refer to the [relative section](./customizing-containerd.md) keeping in mind that the variables are similar but different:
As of now, gVisor support is implemented but broken. See [gvisor/issue/3283](https://github.com/google/gvisor/issues/3283). Refer to the [relative section](./customizing-containerd.md) keeping in mind that the variables are similar but different:

```json
{
"crio_gvisor_runtime": true,
"crio_gvisor_version": "yyyymmdd", // or latest
"crio_gvisor_version": "yyyymmdd", // or "latest"
}
```

For example you can build the qcow2 image with gvisor enabled with this snippet:
For example, you can build the qcow2 image with gVisor enabled with this command:

```sh
PACKER_FLAGS="--var 'crio_gvisor_runtime=true'" make build-qemu-ubuntu-2204-crio
Expand Down
2 changes: 1 addition & 1 deletion images/capi/ansible/roles/crio/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 The Kubernetes Authors.
# Copyright 2024 The Kubernetes Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion images/capi/ansible/roles/crio/tasks/debian.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 The Kubernetes Authors.
# Copyright 2024 The Kubernetes Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion images/capi/ansible/roles/crio/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 The Kubernetes Authors.
# Copyright 2024 The Kubernetes Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion images/capi/ansible/roles/crio/tasks/redhat.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2018 The Kubernetes Authors.
# Copyright 2024 The Kubernetes Authors.

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ runtime_path = "/usr/local/bin/runsc"
runtime_type = "oci"
{% endif %}

{{crio_additional_settings | b64decode}}
{{crio_additional_settings | b64decode}}
2 changes: 1 addition & 1 deletion images/capi/packer/qemu/qemu-ubuntu-2004.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
"iso_url": "http://cdimage.ubuntu.com/ubuntu-legacy-server/releases/20.04/release/ubuntu-20.04.1-legacy-server-amd64.iso",
"os_display_name": "Ubuntu 20.04",
"shutdown_command": "shutdown -P now"
}
}
2 changes: 1 addition & 1 deletion images/capi/packer/qemu/qemu-ubuntu-2204-crio.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
"os_display_name": "Ubuntu 22.04",
"shutdown_command": "shutdown -P now",
"unmount_iso": "true"
}
}
2 changes: 1 addition & 1 deletion images/capi/packer/qemu/qemu-ubuntu-2204-efi.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
"os_display_name": "Ubuntu 22.04",
"shutdown_command": "shutdown -P now",
"unmount_iso": "true"
}
}
2 changes: 1 addition & 1 deletion images/capi/packer/qemu/qemu-ubuntu-2204.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
"os_display_name": "Ubuntu 22.04",
"shutdown_command": "shutdown -P now",
"unmount_iso": "true"
}
}

0 comments on commit e7edde7

Please sign in to comment.