Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation links hard-coded to capz.k8s.io #5123

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR fixes some broken link errors that are caused by links hard-coded to capz.k8s.io instead of the local file, which will cause issues if locations or names of files are changed between versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix documentation links hard-coded to capz.k8s.io

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@willie-yao
Copy link
Contributor Author

/assign @nojnhuh

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@willie-yao willie-yao mentioned this pull request Sep 10, 2024
4 tasks
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60c250b2c1981145a9aaef43d3c57baed8d775ef

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (b4b5087) to head (d857e8c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5123      +/-   ##
==========================================
- Coverage   51.25%   51.25%   -0.01%     
==========================================
  Files         273      273              
  Lines       24651    24651              
==========================================
- Hits        12636    12634       -2     
- Misses      11229    11231       +2     
  Partials      786      786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 25d5985 into kubernetes-sigs:main Sep 10, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 10, 2024
@willie-yao
Copy link
Contributor Author

/cherry-pick release-1.16

@k8s-infra-cherrypick-robot

@willie-yao: #5123 failed to apply on top of branch "release-1.16":

Applying: Fix broken links
Using index info to reconstruct a base tree...
M	docs/book/src/roadmap.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/roadmap.md
CONFLICT (content): Merge conflict in docs/book/src/roadmap.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix broken links
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants