Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v1.16.1 #5122

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds a changelog file for the impending CAPZ v1.16.1 patch release.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@willie-yao
Copy link
Contributor Author

willie-yao commented Sep 10, 2024

/assign @jackfrancis

@willie-yao
Copy link
Contributor Author

/assign @nojnhuh

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (25d5985) to head (153d868).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5122   +/-   ##
=======================================
  Coverage   51.25%   51.25%           
=======================================
  Files         273      273           
  Lines       24651    24651           
=======================================
+ Hits        12634    12636    +2     
+ Misses      11231    11229    -2     
  Partials      786      786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor Author

Gonna open a separate PR to fix hard-coded links to capz.sigs.k8s.io instead of using local files https://github.com/kubernetes-sigs/cluster-api-provider-azure/actions/runs/10797918901/job/29950239288?pr=5122

@willie-yao willie-yao changed the title Add changelog for v1.16.1 WIP: Add changelog for v1.16.1 Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87d2a214490bdf6f523e396ec537d1e2fc6023ec

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@willie-yao
Copy link
Contributor Author

/hold
@nojnhuh Will need to fix the links in the docs. I'll just do it in this PR and then fix it upstream if that's okay!

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 10, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 10, 2024

@willie-yao Do we also need the link updates on the release branch?

@willie-yao
Copy link
Contributor Author

@willie-yao Do we also need the link updates on the release branch?

Yes I think so. I'll create a separate PR to main with the link fix commit and then backport it to 1.16

@willie-yao
Copy link
Contributor Author

Opened #5123 PTAL @nojnhuh

@willie-yao willie-yao changed the title WIP: Add changelog for v1.16.1 Add changelog for v1.16.1 Sep 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@willie-yao
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49b42dc2f6c9c089c5bb62fb07da1ce63122b241

@k8s-ci-robot k8s-ci-robot merged commit 1b87cf0 into kubernetes-sigs:main Sep 10, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants