-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed RosaMachinePool typo. #5244
🐛 Fixed RosaMachinePool typo. #5244
Conversation
|
Hi @tinaafitz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@serngawy, Please review. |
d796cbd
to
a91fac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tina , sounds good please add 🐛 to the PR title so it can pass the verify job
/ok-to-test |
1 similar comment
/ok-to-test |
apidiff is failing because a string value for a condition type was changed. As long as you're ok with that @serngawy, then that's nothing to worry about. /test pull-cluster-api-provider-aws-test Was out of capacity at the time. |
Yes, its okay better to fix typo |
d1bd52e
to
fcbd61e
Compare
/retest |
@tinaafitz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@tinaafitz the API diff test won't pass since the strings are new values. That tests exists to give us a heads up that the API's changing and could lead to compatibility issues. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, @nrb. That makes sense. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is fixing a
RosaMchinePoolReady
typo.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Discovered issue while working on https://issues.redhat.com/browse/ACM-16063
Special notes for your reviewer:
Checklist:
Release note: