Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed RosaMachinePool typo. #5244

Merged

Conversation

tinaafitz
Copy link
Contributor

@tinaafitz tinaafitz commented Dec 10, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR is fixing a RosaMchinePoolReady typo.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Discovered issue while working on https://issues.redhat.com/browse/ACM-16063

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fixed RosaMachinePool typo.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2024
Copy link

linux-foundation-easycla bot commented Dec 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tinaafitz / name: Tina Fitzgerald (fcbd61e)

@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tinaafitz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@tinaafitz
Copy link
Contributor Author

@serngawy, Please review.

@tinaafitz tinaafitz changed the title WIP Fixed RosaMachinePoolReady typo. Fixed RosaMachinePool typo. Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 12, 2024
@tinaafitz tinaafitz force-pushed the fix_rosamachinepoolready_typo branch from d796cbd to a91fac5 Compare December 13, 2024 15:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2024
Copy link
Contributor

@serngawy serngawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tina , sounds good please add 🐛 to the PR title so it can pass the verify job

@tinaafitz tinaafitz changed the title Fixed RosaMachinePool typo. 🐛 Fixed RosaMachinePool typo. Dec 13, 2024
@nrb
Copy link
Contributor

nrb commented Dec 13, 2024

/ok-to-test

1 similar comment
@nrb
Copy link
Contributor

nrb commented Dec 13, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2024
@nrb
Copy link
Contributor

nrb commented Dec 13, 2024

apidiff is failing because a string value for a condition type was changed. As long as you're ok with that @serngawy, then that's nothing to worry about.

/test pull-cluster-api-provider-aws-test

Was out of capacity at the time.

@serngawy
Copy link
Contributor

apidiff is failing because a string value for a condition type was changed. As long as you're ok with that @serngawy, then that's nothing to worry about.

/test pull-cluster-api-provider-aws-test

Was out of capacity at the time.

Yes, its okay better to fix typo

@tinaafitz tinaafitz changed the title 🐛 Fixed RosaMachinePool typo. wip 🐛 Fixed RosaMachinePool typo. Dec 13, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@tinaafitz tinaafitz changed the title wip 🐛 Fixed RosaMachinePool typo. 🐛 Fixed RosaMachinePool typo. Dec 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@tinaafitz tinaafitz force-pushed the fix_rosamachinepoolready_typo branch from d1bd52e to fcbd61e Compare December 13, 2024 19:39
@tinaafitz
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@tinaafitz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main fcbd61e link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor

nrb commented Dec 18, 2024

@tinaafitz the API diff test won't pass since the strings are new values. That tests exists to give us a heads up that the API's changing and could lead to compatibility issues.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1ee022e into kubernetes-sigs:main Dec 18, 2024
18 of 19 checks passed
@tinaafitz
Copy link
Contributor Author

Thanks, @nrb. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants