Skip to content

Commit

Permalink
Fixed RosaMachinePoolReady typo and changed commit messsage.
Browse files Browse the repository at this point in the history
  • Loading branch information
tinaafitz committed Dec 13, 2024
1 parent df09e6c commit a91fac5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion exp/api/v1beta2/conditions_consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const (

const (
// RosaMachinePoolReadyCondition condition reports on the successful reconciliation of rosa machinepool.
RosaMachinePoolReadyCondition clusterv1.ConditionType = "RosaMchinePoolReady"
RosaMachinePoolReadyCondition clusterv1.ConditionType = "RosaMachinePoolReady"
// RosaMachinePoolUpgradingCondition condition reports whether ROSAMachinePool is upgrading or not.
RosaMachinePoolUpgradingCondition clusterv1.ConditionType = "RosaMchinePoolUpgrading"

Expand Down
2 changes: 1 addition & 1 deletion exp/controllers/rosamachinepool_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (r *ROSAMachinePoolReconciler) Reconcile(ctx context.Context, req ctrl.Requ

if !controlPlane.Status.Ready && controlPlane.ObjectMeta.DeletionTimestamp.IsZero() {
log.Info("Control plane is not ready yet")
err := machinePoolScope.RosaMchinePoolReadyFalse(expinfrav1.WaitingForRosaControlPlaneReason, "")
err := machinePoolScope.RosaMachinePoolReadyFalse(expinfrav1.WaitingForRosaControlPlaneReason, "")
return ctrl.Result{}, err
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/cloud/scope/rosamachinepool.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,9 @@ func (s *RosaMachinePoolScope) Namespace() string {
return s.Cluster.Namespace
}

// RosaMchinePoolReadyFalse marks the ready condition false using warning if error isn't
// RosaMachinePoolReadyFalse marks the ready condition false using warning if error isn't
// empty.
func (s *RosaMachinePoolScope) RosaMchinePoolReadyFalse(reason string, err string) error {
func (s *RosaMachinePoolScope) RosaMachinePoolReadyFalse(reason string, err string) error {
severity := clusterv1.ConditionSeverityWarning
if err == "" {
severity = clusterv1.ConditionSeverityInfo
Expand Down

0 comments on commit a91fac5

Please sign in to comment.