🌱 Tag S3 bucket as owned by cluster #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
vincepri
reviewed
Oct 9, 2023
| ClusterName: s.scope.Name(), | ||
| Lifecycle: infrav1.ResourceLifecycleOwned, | ||
| Name: nil, | ||
| Role: aws.String("node"), |
There was a problem hiding this comment.
Maybe I misunderstand the question. Do you mean to rather use "common" (CommonRoleTagValue) as we do for VPC, gateways and such? I used "node" because the bucket seems only used for bootstrapping purposes and therefore relates to nodes, similar to how ASGs are tagged, for example.
|
/retitle 🌱 Tag S3 bucket as owned by cluster |
k8s-ci-robot
changed the title
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
I noticed that the S3 bucket isn't tagged. Some companies use AWS tags for grouping resources, calculating costs, or to clean up accidental remainders of clusters that CAPI/CAPA couldn't delete after a misconfiguration. With this change, the bucket is tagged as belonging to the cluster.
I'm not entirely sure if there's a use case where people provide a shared S3 bucket. In the S3 service code, there's such a hint in a
TODO. For that case, we would need to introduceAWSCluster.spec.s3Bucket.additionalTagswhere users can setsigs.k8s.io/cluster-api-provider-aws/cluster/...=shared. And the implementation should be changed to only upsert tags instead of overwriting them, given that multipleAWSClusterobjects could reconcile the same bucket. Let me know if that's a supported use case.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):n/a
Checklist:
Release note: