Expose additionalTags value from CAPA in cluster-aws and cluster-eks

[T-Kukawka]

Based on the CAPA implementation: kubernetes-sigs/cluster-api-provider-aws#1113

We should be able to expose additionalTags value in our cluster-aws and cluster-eks for tagging the AWS Resources. This feature is highly wanted by customers either for cost tracking or security processes.

Initial implementation should consider the population of the tags during creation of clusters only, however besides CAPI controllers we have to extend population of the tags also within our custom controllers.

[calvix]

TODO

• cluster aws - expose tag value - expose-aws-additional-tags cluster-aws#405
• cluster-eks expose tag value - expose-aws-additional-tags cluster-eks#30
• aws-resolver-rules-operator - add-tags-to-resources aws-resolver-rules-operator#105
• irsa-operator capi-add-tags-to-resources irsa-operator#170
• capa-iam-operator add-tags-to-resources2 capa-iam-operator#211
• aws-vpc-operator - looks like that was already written with the idea of using the additional tags field, no work need to be done here
• aws-network-topology-operator is deprecated and will be removed
• S3 buckets created by CAPA controller - waiting for a new release

[calvix]

S3 buckets for ignition are not tagged in the latest CAPA controller release, I was checking the code and found out that @AndiDog actually implemented it :p wow
kubernetes-sigs/cluster-api-provider-aws#4518

so the last part is blocked by upstream release

[AndiDog]

I'll try to cherry-pick the S3 tagging change into our fork

[calvix]

unfortunately, the changes in capa-controller only add basic tags

sigs.k8s.io/cluster-api-provider-aws/role: node
sigs.k8s.io/cluster-api-provider-aws/cluster/vac0t: owned

but do not add tags under

 #: kcapa get awscluster vac0t -o yaml  | grep -A 3 spec
spec:
  additionalTags:
    giantswarm.io/cluster: vac0t
    vaclav: vaclavTag

that means customer tags are not applied, this will need to be fixed in the capa controller

[AndiDog]

I'll take care of AdditionalTags – not hard to do.

[AndiDog]

Fixed in kubernetes-sigs/cluster-api-provider-aws#4625 and I'll cherry-pick it immediately into our fork because it's so straightforward and unlikely that the PR content changes.

[calvix]

LGTM