Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rosaControlPlane for managed kubernetes #4453

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Introduce rosaControlPlane for managed kubernetes #4453

merged 8 commits into from
Oct 5, 2023

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Aug 17, 2023 •
edited
Loading

What type of PR is this?

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

Continuation of #4344

This introduces support ROSA analogous to the EKS implementation.

This branch introduces a new ROSAControlPlane CRD and controller which enables functional ROSA Cluster creation with the proper yaml definition. We plan to iterate and follow up to flesh out design and implementation for the API, cluster deletion, day 2 changes, machine management via rosaMachinePools, etc.
This first iteration is meant to be little more than a starting common ground for collaboration.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Introduce ROSA ControlPlane for managed kubernetes

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @muraee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muraee
Copy link
Contributor Author

muraee commented Aug 17, 2023

cc @vincepri @richardcase Alberto is on PTO and asked to continue this work and see it through.

@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2023
@muraee
Copy link
Contributor Author

muraee commented Aug 21, 2023

/test pull-cluster-api-provider-aws-build

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Aug 21, 2023

/test pull-cluster-api-provider-aws-build

richardcase
richardcase reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @muraee . Some initial comments. Feel free to reach out to me if you have any questions.

api/v1beta2/rosacluster_types.go Outdated Show resolved Hide resolved
api/v1beta2/rosacluster_types.go Outdated Show resolved Hide resolved
controllers/rosacluster_controller.go Outdated Show resolved Hide resolved
controlplane/rosa/api/v1beta2/groupversion_info.go Outdated Show resolved Hide resolved
controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Outdated Show resolved Hide resolved
controlplane/rosa/controllers/rosacontrolplane_controller.go Outdated Show resolved Hide resolved
feature/feature.go Outdated Show resolved Hide resolved
pkg/cloud/scope/rosacontrolplane.go Outdated Show resolved Hide resolved
pkg/cloud/scope/rosacontrolplane.go Outdated Show resolved Hide resolved
pkg/cloud/scope/rosacontrolplane.go Outdated Show resolved Hide resolved
@muraee muraee force-pushed the rosa-poc branch 2 times, most recently from 1e17892 to 6408e5b Compare August 24, 2023 10:25
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2023
@richardcase
Copy link
Member

@muraee - lets find a time to chat about the network requirements of rosa and the crds.

@muraee
Copy link
Contributor Author

muraee commented Sep 5, 2023

/test pull-cluster-api-provider-aws-build

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Sep 5, 2023

/test pull-cluster-api-provider-aws-build

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2023
@muraee
Copy link
Contributor Author

muraee commented Sep 7, 2023

/test pull-cluster-api-provider-aws-build

@muraee
Copy link
Contributor Author

muraee commented Sep 26, 2023

Build is happy again after kubernetes/test-infra#30792 has merged.

@richardcase @Ankitasw @Skarlso If there are no objections/suggestions, I think this PR is ready to be merged.

@Skarlso
Copy link
Contributor

Skarlso commented Sep 26, 2023

/lgtm

@richardcase for final approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 26, 2023
@Ankitasw Ankitasw mentioned this pull request Sep 27, 2023
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 5, 2023
@muraee
Copy link
Contributor Author

muraee commented Oct 5, 2023

/test pull-cluster-api-provider-aws-verify

@Skarlso
Copy link
Contributor

Skarlso commented Oct 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@Ankitasw
Copy link
Member

Ankitasw commented Oct 5, 2023

/lgtm

@Skarlso
Copy link
Contributor

Skarlso commented Oct 5, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit b36e26e into kubernetes-sigs:main Oct 5, 2023
7 checks passed
@muraee muraee mentioned this pull request Nov 28, 2023
Merged
5 tasks
@muraee muraee mentioned this pull request Feb 8, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@Skarlso Skarlso Skarlso left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@Skarlso Skarlso

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@muraee @k8s-ci-robot @Ankitasw @richardcase @Skarlso @enxebre