-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce rosaControlPlane for managed kubernetes #4344
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Planning to bring this up in next community call Mon 3 Jul |
There's no meeting today, so 10Jul. |
@enxebre Can you rebase? |
/milestone v2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall this be an experimental feature first and then be graduated?
If yes, then it would require a bit of refactoring, as we follow for exp APIs and controllers.
Good point @Ankitasw . Yes i think we do need to sit this behind a feature flag initially like we did when we added other significant new features. |
Makes sense, I'll account for it while rebasing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a05ded4
to
aecf29b
Compare
Rebased, put behind feature gate and started to gather follow ups here #4431 |
it would be good if we can add an OWNER file or something to allow us to approve PRs related to the ROSA provider without needing to bother the maintainers every time. |
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=ROSAclusters,verbs=get;list;watch;update;patch;delete | ||
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=ROSAclusters/status,verbs=get;update;patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be these resources in lowercase?
Adding a sub-owner file sounds good to me, although I'd generally prefer a steady stream of contribution/reviews before we add approver rights. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In favor of #4453 |
What type of PR is this?
What this PR does / why we need it:
This introduces support ROSA analogous to the EKS implementation.
This branch introduces a new ROSAControlPlane CRD and controller which enables functional ROSA Cluster creation with the proper yaml definition. We plan to iterate and follow up to flesh out design and implementation for the API, cluster deletion, day 2 changes, machine management via rosaMachinePools, etc.
This first iteration is meant to be little more than a starting common ground for collaboration.
Let's discuss on next community meeting next steps.
cc @vincepri @richardcase
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: