Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add S390x support in affinity rule #503

Merged
merged 7 commits into from
May 28, 2024
Merged

feat: add S390x support in affinity rule #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ec0860
Update runtime.go
modassarrana89 Apr 30, 2024
40b250b
Update servingruntime_controller.golden
modassarrana89 Apr 30, 2024
c27c098
Update servingruntime_controller.golden
modassarrana89 Apr 30, 2024
589b584
Update runtime.go
modassarrana89 May 15, 2024
40d0689
Update runtime.go
modassarrana89 May 15, 2024
1c1f188
lint runtime.go
ckadner May 27, 2024
6ceb565
Merge branch 'main' into s390x
ckadner May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions controllers/modelmesh/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,17 +341,15 @@ func addDomainSocketMount(rts *kserveapi.ServingRuntimeSpec, c *corev1.Container
func (m *Deployment) addPassThroughPodFieldsToDeployment(deployment *appsv1.Deployment) error {
rts := m.SRSpec
// these fields map directly to pod spec fields
// supported architectures are "amd64" and "arm64", "ppc64le"
// and "s390x" are not supported by tensorflow
// (https://github.com/kserve/modelmesh-runtime-adapter/pull/38#discussion_r1156749259)
// supported architectures are "amd64", "arm64" and "s390x"
deployment.Spec.Template.Spec.NodeSelector = rts.NodeSelector
deployment.Spec.Template.Spec.Tolerations = rts.Tolerations
archNodeSelector := corev1.NodeSelectorTerm{
MatchExpressions: []corev1.NodeSelectorRequirement{
{
Key: "kubernetes.io/arch",
Operator: corev1.NodeSelectorOpIn,
Values: []string{"amd64", "arm64"},
Values: []string{"amd64", "arm64", "s390x"},
},
},
}
Expand Down
8 changes: 8 additions & 0 deletions controllers/testdata/servingruntime_controller.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/mlserver-adapter
Expand Down Expand Up @@ -292,6 +293,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/mlserver-adapter
Expand Down Expand Up @@ -542,6 +544,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- env:
- name: REST_PROXY_LISTEN_PORT
Expand Down Expand Up @@ -814,6 +817,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/mlserver-adapter
Expand Down Expand Up @@ -1061,6 +1065,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/ovms-adapter
Expand Down Expand Up @@ -1300,6 +1305,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/torchserve-adapter
Expand Down Expand Up @@ -1542,6 +1548,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- command:
- /opt/app/triton-adapter
Expand Down Expand Up @@ -1799,6 +1806,7 @@ spec:
values:
- amd64
- arm64
- s390x
containers:
- env:
- name: MODEL_DIRECTORY_PATH
Expand Down
Loading