Split out new crate all-is-cubes-base.
#491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used for all of our conditional `std::error::Error` implementations, which will allow the impls to exist when needed to satisfy `ErrorIfStd` bounds even when the `util` module is split to another crate and therefore won't necessarily share `cfg`s with the code that needs to contain the implementations. All this can hopefully go away some day when `core::error::Error` exists.
kpreid
force-pushed
the
math-split
branch
2 times, most recently
from
9c5c620 to
863ddfc
Compare
It contains the majority of code from the `math` and `util` modules of `all-is-cubes`. This new crate will enable us to use `raycast` in the build script of `all-is-cubes` to generate fully pre-calculated light propagation data. It may also assist in further splitting of `all-is-cubes` into separately compilable parts, if I find such divisions worth making. I chose the name “base” to be sufficiently abstract that it will not become unsuitable for its purpose (being the crate that all others eventually depend on) regardless of exactly what it evolves to contain. I also considered “all-is-cubes-core”, but I feel that only the crate containing `Block` and `Space` deserves that name if I were to use it. Also, because it's now possible and convenient, the macros `notnan`, `rgb_const`, and `rgba_const` have been moved to `all_is_cubes::math`. (This is only possible because macro re-exports can be exported from specific modules, even though `macro_rules` declarations can only be exported from the crate root.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains the majority of code from the
mathandutilmodules ofall-is-cubes.This new crate will enable us to use
raycastin the build script ofall-is-cubesto generate fully pre-calculated light propagation data (#490). It may also assist in further splitting ofall-is-cubesinto separately compilable parts, if I find such divisions worth making.I chose the name “base” to be sufficiently abstract that it will not become unsuitable for its purpose (being the crate that all others eventually depend on) regardless of exactly what it evolves to contain. I also considered “all-is-cubes-core”, but I feel that only the crate containing
BlockandSpacedeserves that name if I were to use it.Also, because it's now possible and convenient, the macros
notnan,rgb_const, andrgba_consthave been moved toall_is_cubes::math. (This is only possible because macro re-exports can be exported from specific modules, even thoughmacro_rulesdeclarations can only be exported from the crate root.)