Skip to content

Commit

Permalink
Rust 1.82: Bump MSRV and remove workarounds.
Browse files Browse the repository at this point in the history
* Remove `allow(unknown_lints)`.
* Remove match arms that are unnecessary due to `min_exhaustive_patterns`
  being stabilized.
  • Loading branch information
kpreid committed Oct 17, 2024
1 parent 319c632 commit d2a4ff9
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ resolver = "2"
# When changing any of these values, be sure to also update the non-workspace packages
# as listed above, if applicable.
edition = "2021"
rust-version = "1.81"
rust-version = "1.82"
license = "MIT OR Apache-2.0"
authors = ["Kevin Reid <[email protected]>"]
# TODO: add homepage = "..." when we have one
Expand Down
2 changes: 0 additions & 2 deletions all-is-cubes-desktop/src/glue/rerun_mesh.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ impl From<mesh::BlockVertex<NoTexture>> for Vertex {
position: v.position.to_f32().to_array().into(),
color: match v.coloring {
mesh::Coloring::Solid(color) => color.to_srgb8().into(),
#[allow(unreachable_patterns)] // TODO: Remove this arm after Rust 1.82
mesh::Coloring::Texture { .. } => unreachable!(),
},
}
}
Expand Down
2 changes: 0 additions & 2 deletions all-is-cubes-ui/src/ui_content/pages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ pub(super) fn new_paused_page(
// TODO: quit_fn should be an async function, but we don't have a way to
// kick off a “Quitting...” task yet.
move || match quit_fn() {
#[allow(unreachable_patterns, reason = "TODO: Remove this arm after Rust 1.82")]
Ok(s) => match s {},
Err(_cancelled) => {

// TODO: display message indicating failure
Expand Down
2 changes: 1 addition & 1 deletion all-is-cubes-wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "all-is-cubes-wasm"
version = "0.8.0"
authors = ["Kevin Reid <[email protected]>"]
edition = "2021"
rust-version = "1.81"
rust-version = "1.82"
description = "Web client for the recursive voxel game All is Cubes."
# TODO: add homepage = "..." when we have one
repository = "https://github.com/kpreid/all-is-cubes"
Expand Down
1 change: 0 additions & 1 deletion all-is-cubes/src/content/palette.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
//
// 0xBB is the sRGB value approximating linear value 0.5.

#![allow(unknown_lints)] // TODO: remove after Rust 1.82 is released
#![allow(clippy::too_long_first_doc_paragraph, reason = "false positive on SVG")]

use crate::math::{rgb_const, Rgb};
Expand Down
1 change: 0 additions & 1 deletion all-is-cubes/src/drawing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ pub fn rectangle_to_aab(rectangle: Rectangle, transform: Gridgid, max_brush: Gri
// way, since it is precisely about identifying the volume occupied by drawing a
// 2D-pixel.

#![allow(unknown_lints)] // TODO: remove after Rust 1.82 is released
#![allow(clippy::too_long_first_doc_paragraph)] // TODO: find better phrasing

if rectangle.size.width == 0 || rectangle.size.height == 0 {
Expand Down

0 comments on commit d2a4ff9

Please sign in to comment.