Development Release 3.0.0 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `CENSUS_API_KEY` envvar
…s for getting an API key
…KEY` environment variable
Docs/improvements
fix(voters): use tract NY-061-014900 instead of 015100
Coverage tests
fixed roll-up tests
solivella
approved these changes
Jan 16, 2024
…e `TRUE`, since `age` and `sex` are now supported
Update test-rollup.R
Allow `age` and `sex` to be `TRUE` in `census_helper_new()`
|
I'm so glad that the age and sex extensions will be enabled in this release! |
geneh0
reviewed
Feb 8, 2024
|
This is one of the reasons it's still not merged. There are a few other little problems + tests that we need to fix up. ---- On Thu, 08 Feb 2024 18:42:41 -0500 ***@***.*** wrote ----
@geneh0 commented on this pull request.
In R/census_helper_v2.R:
}
} else {
census <- census.data[[toupper(state)]]$block
}
+ } else {
+ geo.merge <- geo
+
+ state_must_be_downloaded <- toDownload ||
+ is.null(census.data[[state]]) ||
+ census.data[[state]]$year != year ||
+ # TODO: Why do we always redownload if sex or age == TRUE?
Hi! I was running the age and sex extensions on predownloaded census data and noticed that all the census data is being pulled again. Did anyone look into why this happens?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Awaiting manual review for CRAN approval. Received email CRAN already specifying 5 days. |
Reduced test data size
|
Updated tarball size as per request from Uwe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: