This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
feat: add network encryption recommender #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional recommendation to enable cluster network encryption. Signed-off-by: Alexander Trost <[email protected]>
Signed-off-by: Alexander Trost <[email protected]>
zalsader
approved these changes
Apr 11, 2024
| Title: "Ceph network encryption not active", | ||
| Description: `It is recommended to enable Ceph network encryption for clusters that might be running in \"untrusted\" networks. | ||
| To enable it carefully read the \"encryption.enabled\" settings comments <a class=\"underline\" href=\"https://rook.io/docs/rook/latest-release/CRDs/Cluster/ceph-cluster-crd/#network-configuration-settings\">here</a>.`, | ||
| Level: cephv1.RecommendationLevel_RECOMMENDATION_LEVEL_INFORMAL, |
There was a problem hiding this comment.
On the name of this, does "informal" mean "not formal" or "providing information, informational"? If it's the latter, I suggest renaming this to info.
There was a problem hiding this comment.
I have renamed it to info/INFO, merging now.
There was a problem hiding this comment.
I do not see the change merged, did you push it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional recommendation to enable cluster network encryption.