Merge pull request #350 from koor-tech/feature/ksd-379

pkg/recommender/modules/rook_encryption.go

@@ -0,0 +1,48 @@
+package recommendermodules
+
+import (
+	"context"
+
+	cephv1 "github.com/koor-tech/data-control-center/gen/go/api/resources/ceph/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func init() {
+	moduleFactories["k8s_resources"] = NewRookEncryption
+}
+
+func NewRookEncryption() (Module, error) {
+	return &RookEncryption{}, nil
+}
+
+type RookEncryption struct {
+	Module
+}
+
+func (m *RookEncryption) GetName() string {
+	return "rook_encryption"
+}
+
+func (m *RookEncryption) Run(ctx context.Context, p *Params) ([]*cephv1.ClusterRecommendation, error) {
+	recs := []*cephv1.ClusterRecommendation{}
+
+	clusters, err := p.K8S.GetRookClient().CephV1().CephClusters(p.Namespace).List(ctx, v1.ListOptions{})
+	if err != nil {
+		return nil, err
+	}
+	for _, item := range clusters.Items {
+		if item.Spec.Network.Connections.Encryption != nil && item.Spec.Network.Connections.Encryption.Enabled {
+			continue
+		}
+
+		recs = append(recs, &cephv1.ClusterRecommendation{
+			Title: "Ceph network encryption not active",
+			Description: `It is recommended to enable Ceph network encryption for clusters that might be running in \"untrusted\" networks.
+To enable it carefully read the \"encryption.enabled\" settings comments <a class=\"underline\" href=\"https://rook.io/docs/rook/latest-release/CRDs/Cluster/ceph-cluster-crd/#network-configuration-settings\">here</a>.`,
+			Level: cephv1.RecommendationLevel_RECOMMENDATION_LEVEL_INFORMAL,
+			Type:  cephv1.RecommendationType_RECOMMENDATION_TYPE_CLUSTER,
+		})
+	}
+
+	return recs, nil
+}

pkg/recommender/recommender.go

@@ -2,6 +2,7 @@ package recommender
 
 import (
 	"context"
+	"slices"
 	"sync"
 	"time"
 
@@ -118,6 +119,9 @@ func (r *Recommender) Gather() error {
 	r.mutex.Lock()
 	defer r.mutex.Unlock()
 
+	slices.SortFunc(recommendations, func(a *cephv1.ClusterRecommendation, b *cephv1.ClusterRecommendation) int {
+		return int(b.Level - a.Level)
+	})
 	r.recommendations = recommendations
 
 	return errs

src/components/cluster/services/MgrService.vue

@@ -3,7 +3,7 @@ import { ClipboardIcon } from 'mdi-vue3';
 import type { MgrService } from '~~/gen/ts/api/resources/ceph/v1/stats_pb';
 import ServiceLiItem from '~/components/cluster/services/ServiceLiItem.vue';
 import ServiceBox from '~/components/cluster/services/ServiceBox.vue';
-import Time from '~/components/partials/elements/Time.vue';
+import GenericTime from '~/components/partials/elements/GenericTime.vue';
 import GenericBadge from '~/components/partials/GenericBadge.vue';
 
 defineProps<{
@@ -27,7 +27,7 @@ defineProps<{
             <ServiceLiItem>
                 <template #default> Updated Since </template>
                 <template #content>
-                    <Time :value="stats.updatedSince" />
+                    <GenericTime :value="stats.updatedSince" />
                 </template>
             </ServiceLiItem>
         </template>

src/components/cluster/services/MonService.vue

@@ -4,7 +4,7 @@ import type { MonService } from '~~/gen/ts/api/resources/ceph/v1/stats_pb';
 import GenericBadge from '~/components/partials/GenericBadge.vue';
 import ServiceLiItem from '~/components/cluster/services/ServiceLiItem.vue';
 import ServiceBox from '~/components/cluster/services/ServiceBox.vue';
-import Time from '~/components/partials/elements/Time.vue';
+import GenericTime from '~/components/partials/elements/GenericTime.vue';
 
 defineProps<{
     stats: MonService;
@@ -36,14 +36,14 @@ defineProps<{
             <ServiceLiItem>
                 <template #default> Created Since </template>
                 <template #content>
-                    <Time :value="stats.createdSince" />
+                    <GenericTime :value="stats.createdSince" />
                 </template>
             </ServiceLiItem>
 
             <ServiceLiItem>
                 <template #default> Updated Since </template>
                 <template #content>
-                    <Time :value="stats.updatedSince" />
+                    <GenericTime :value="stats.updatedSince" />
                 </template>
             </ServiceLiItem>
         </template>

src/components/cluster/services/OsdService.vue

@@ -3,7 +3,7 @@ import { TableIcon } from 'mdi-vue3';
 import type { OsdService } from '~~/gen/ts/api/resources/ceph/v1/stats_pb';
 import ServiceLiItem from '~/components/cluster/services/ServiceLiItem.vue';
 import ServiceBox from '~/components/cluster/services/ServiceBox.vue';
-import Time from '~/components/partials/elements/Time.vue';
+import GenericTime from '~/components/partials/elements/GenericTime.vue';
 
 defineProps<{
     stats: OsdService;
@@ -38,14 +38,14 @@ defineProps<{
             <ServiceLiItem>
                 <template #default> In Updated </template>
                 <template #content>
-                    <Time :value="stats.osdInUpdatedSince" />
+                    <GenericTime :value="stats.osdInUpdatedSince" />
                 </template>
             </ServiceLiItem>
 
             <ServiceLiItem>
                 <template #default> Up Updated </template>
                 <template #content>
-                    <Time :value="stats.osdUpUpdatedSince" />
+                    <GenericTime :value="stats.osdUpUpdatedSince" />
                 </template>
             </ServiceLiItem>
         </template>

src/components/recommender/RecommenderList.vue

@@ -49,9 +49,9 @@ async function listClusterRecommendations(): Promise<ListClusterRecommendationsR
             <DataNoDataBlock v-else-if="data === null || data === undefined" />
 
             <template v-else>
-                <div class="mt-2 gap-2 grid grid-col-2">
+                <div class="max-w-3xl mt-2 gap-2 grid grid-col-2">
                     <RecommenderListEntry
-                        v-for="recommendation in data.recommendations.sort((a, b) => a.type - b.type)"
+                        v-for="recommendation in data.recommendations"
                         :key="recommendation.title"
                         :recommendation="recommendation"
                     />

src/components/recommender/RecommenderListEntry.vue

@@ -17,9 +17,11 @@ defineProps<{
                 <InformationIcon class="h-5 w-auto" :class="getRecommendationLevelTextColor(recommendation.level)" />
                 {{ RecommendationLevel[recommendation.level] }}
             </GenericBadge>
+
             {{ recommendation.title }}
         </h3>
-        <p class="text-base">{{ recommendation.description }}</p>
+        <!-- eslint-disable-next-line vue/no-v-html -->
+        <p class="text-base" v-html="recommendation.description"></p>
         <template v-if="recommendation.extraData && recommendation.extraData.case !== undefined">
             <hr class="my-1" />
             <p v-if="recommendation.extraData.case === 'recommendedValue'" class="text-sm">

src/error.vue

@@ -1,3 +1,4 @@
+<!-- eslint-disable vue/multi-word-component-names -->
 <script setup lang="ts">
 import { useClipboard } from '@vueuse/core';
 import HeroFull from '~/components/partials/HeroFull.vue';