Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let users install applications from the GitOps catalog that won't work on k3d #202

Closed
wants to merge 1 commit into from

Conversation

tomekz
Copy link

@tomekz tomekz commented Oct 17, 2023

Linked issue #1810

Catalog PR

scope

  • don't load the applications with k3d set to false to console

test

I've tested this in the console on localhost. The observability apps don't show DataDog anymore (the only catalog app so far that doesn't work on k3d)

Screenshot 2023-10-17 at 22 43 06

@fharper
Copy link
Contributor

fharper commented Oct 23, 2023

@tomekz can you sign your commit please? In the meantime, I'll review the PRs for this.

I read somewhere you did, but maybe you didn't push your change as they are not signed. If you're successful, you'll see the verified badge next to them, like this.

CleanShot 2023-10-23 at 15 41 14@2x

@fharper fharper self-requested a review October 23, 2023 19:42
@fharper fharper added the enhancement New feature or request label Oct 23, 2023
@fharper
Copy link
Contributor

fharper commented Oct 23, 2023

@tomekz
Copy link
Author

tomekz commented Oct 24, 2023

@fharper can you apply the following to both of my PRs:
"Your PR/MR was submitted to a repository that is not participating in Hacktoberfest. Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR/MR"

@fharper
Copy link
Contributor

fharper commented Oct 24, 2023

@tomekz I added the label.

Got side-tracked with something else yesterday, will test your PRs for sure today!

@fharper
Copy link
Contributor

fharper commented Oct 24, 2023

So, sorry for the delay, @CristhianF7 will review this PR instead of me as I cannot test it right now with k3d. Tomorrow should be done.

@fharper fharper requested review from CristhianF7 and removed request for fharper October 24, 2023 19:26
@fharper
Copy link
Contributor

fharper commented Nov 15, 2023

As discussed in Slack, we won't move forward with this PR.

@fharper fharper closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants