Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let users install applications from the GitOps catalog that won't work on k3d #1810

Closed
1 of 2 tasks
fharper opened this issue Sep 13, 2023 · 5 comments
Closed
1 of 2 tasks
Labels
console Specific to the console application feature Something new good first issue Good for newcomers

Comments

@fharper
Copy link
Contributor

fharper commented Sep 13, 2023

What is your feature idea?

Some applications from the GitOps catalog can't be installed on k3d (ex.: DataDog), and now that the catalog is also available on k3d, we probably want to prevent the users from installing those locally.

Why is it needed?

It will prevent installing applications that won't work, so the users won't try to fix something that shouldn't, and we won't get support request for those.

I suggest we add a new field in the index.yaml, like k3d (@donnalux can find a better name for it) which should be set to false if not working on k3d, and true if it is. We could also default to true if the new field is not set.

Is this missing feature preventing you from using kubefirst?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added feature Something new console Specific to the console application labels Sep 13, 2023
@fharper
Copy link
Contributor Author

fharper commented Sep 20, 2023

@donnalux agreed with the idea.

On the console side, it would just mean to not load the application with that property.

@tomekz
Copy link

tomekz commented Oct 12, 2023

Hey I would like to work on this issue

@fharper
Copy link
Contributor Author

fharper commented Oct 13, 2023

That is awesome @tomekz. Let me message you on Slack so we can discuss this :)

@tomekz
Copy link

tomekz commented Oct 17, 2023

Hey @fharper

Here are linked PRs

@fharper
Copy link
Contributor Author

fharper commented Oct 27, 2023

As shared with you on the Slack community, we decided to go another way which is a bit more complicated, but will let us cover more case scenarios.

@fharper fharper closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Specific to the console application feature Something new good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants