Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 3.2 #3786

Merged
merged 22 commits into from
Aug 17, 2022
Merged

Upgrade to Django 3.2 #3786

merged 22 commits into from
Aug 17, 2022

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Apr 28, 2022

Description

Upgrade code base to use Django 3.2 LTS

Additional info

  • Set DEFAULT_AUTO_FIELD
  • django.contrib.postgres.fields.JSONField deprecated. Replaced with models.JSONField [ref]
  • Constance stuck at 2.8.0 in pipy (2.9.0 is 3.10 compatible)
  • django-trench is only marked as compatible with Python 3.9 and Django 3.0. Also stuck at 0.3.0 in pipy but GitHub project only has 0.3.1. Another PR has been created to updated it Update django-trench to 0.3.1 #3793
  • Get rid of prod.* file for pip dependencies (Make it consistent with KoBoCAT)

Related issues

kobotoolbox/kobocat#815

@noliveleger noliveleger marked this pull request as draft April 28, 2022 20:34
@noliveleger noliveleger mentioned this pull request May 3, 2022
7 tasks
 # Conflicts:
 #	dependencies/pip/dev_requirements.txt
 #	dependencies/pip/external_services.txt
 #	dependencies/pip/requirements.txt
 #	kpi/deployment_backends/kc_access/storage.py
@noliveleger noliveleger marked this pull request as ready for review May 4, 2022 21:08
@jnm jnm changed the title Upgrade to django3.2 Upgrade to Django 3.2 May 25, 2022
@bufke
Copy link
Contributor

bufke commented Jul 25, 2022

Dockerfile has COPY ./dependencies/pip/external_services.txt "/tmp/pip_dependencies.txt" but that file no longer exists.

@noliveleger
Copy link
Contributor Author

Dockerfile has COPY ./dependencies/pip/external_services.txt "/tmp/pip_dependencies.txt" but that file no longer exists.

🤦, bad previous merge when we introduced multi builds.

@noliveleger noliveleger requested a review from bufke July 29, 2022 14:46
@noliveleger noliveleger assigned bufke and unassigned jnm Aug 16, 2022
@noliveleger noliveleger force-pushed the upgrade-to-django3.2 branch from 7eb55a1 to 1909a7b Compare August 16, 2022 13:18
@bufke bufke merged commit 0836257 into beta Aug 17, 2022
@noliveleger noliveleger deleted the upgrade-to-django3.2 branch August 17, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants