Upgrade to Django 3.2 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
force-pushed
the
upgrade-django3.2
branch
from
177334c to
8540147
Compare
noliveleger
force-pushed
the
upgrade-django3.2
branch
from
f43e2c4 to
21d7b60
Compare
noliveleger
force-pushed
the
upgrade-django3.2
branch
from
e519cc6 to
8c1ddd0
Compare
noliveleger
force-pushed
the
upgrade-django3.2
branch
from
8c1ddd0 to
60f0453
Compare
# Conflicts: # dependencies/pip/dev_requirements.txt # dependencies/pip/prod.txt # dependencies/pip/requirements.txt
# Conflicts: # dependencies/pip/prod.txt # dependencies/pip/requirements.in # onadata/apps/logger/models/instance.py # onadata/settings/base.py
bufke
reviewed
Aug 15, 2022
dependencies/pip/requirements.in
Outdated
| @@ -13,7 +13,7 @@ https://bitbucket.org/fomcl/savreaderwriter/downloads/savReaderWriter-3.3.0.zip# | |||
| -e git+https://github.com/kobotoolbox/ssrf-protect@9b97d3f0fd8f737a38dd7a6b64efeffc03ab3cdd#egg=ssrf_protect | |||
|
|
|||
| # Regular PyPI packages | |||
| Django>=2.2,<2.3 | |||
| Django==3.2 | |||
There was a problem hiding this comment.
Don't use exact version of Django, use >=,< syntax
There was a problem hiding this comment.
🤦 I thought I already changed it when you made me change it in KPI.
Done!
bufke
requested changes
Aug 15, 2022
bufke
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Django code to latest Django LTS
Additional info
3.12.3.4.0.0and above does not work with MockMongo.logger.instanceandviewer.parsed_instanceid field toBigAutoField. May be very long on big tables?dependencies/pip/prod.*(moveuWSGIinrequirements.*as per internal discussion and match KPI requirements)Related issues
closes #762
related to kobotoolbox/kobo-docker#335
related to kobotoolbox/kpi#3786