Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rewrite for route #96

Merged
merged 1 commit into from
Feb 20, 2024
Merged

added rewrite for route #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../routes/_main+/$account+/$project+/$environment+/router+/$router+/routes/handle-route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,13 @@ const Root = (props: IDialog) => {
path: r.path,
app: r.app,
port: r.port,
rewrite: r.rewrite,
})) || []),
{
path: `/${val.path}`,
app: val.app,
port: parseInt(val.port, 10),
rewrite: val.reWrite,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (llm): The property rewrite is being added with a value from val.reWrite. It's important to ensure consistency in naming conventions. Here, rewrite is all lowercase, whereas reWrite uses camelCase. If this inconsistency is not intentional, consider aligning them to avoid potential confusion or bugs related to naming discrepancies.

},
],
},
Expand Down
Loading