-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(common/web/types): unit tests for unicodeset-parser-api #12714
Merged
markcsinclair
merged 6 commits into
master
from
test/common/web/types/9052-unit-tests-unicodeset-parser-api
Nov 29, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
acf156b
chore(common/web): add test-unicodeset-parser.ts to test UnicodeSet
markcsinclair 6bc46b0
chore(common/web): Merge branch 'master' into test/common/web/types/9…
markcsinclair a2cb00a
chore(common/web): add copyright banner
markcsinclair 3de4f99
chore(common/web): remove MockUnicodeSet as unnecessary
markcsinclair 1d0dddb
chore(common/web): Merge branch 'master' into test/common/web/types/9…
markcsinclair eccc7ed
chore(common/web): add blank line at end of file
markcsinclair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
common/web/types/test/ldml-keyboard/test-unicodeset-parser-api.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Keyman is copyright (C) SIL Global. MIT License. | ||
* | ||
* Created by Dr Mark C. Sinclair on 2024-11-28 | ||
* | ||
* Test code for unicodeset-parser-api.ts | ||
*/ | ||
|
||
import 'mocha'; | ||
import { assert } from 'chai'; | ||
import { UnicodeSet } from '../../src/ldml-keyboard/unicodeset-parser-api.js'; | ||
|
||
class MockUnicodeSet extends UnicodeSet { | ||
constructor(public pattern: string, public ranges: number[][]) { | ||
super(pattern, ranges); // does nothing | ||
this.pattern = pattern; | ||
this.ranges = ranges; | ||
} | ||
} | ||
|
||
describe('Test of Unicode-Parser-API', () => { | ||
describe('Test UnicodeSet', () => { | ||
it('can provide a correct ranges length', () => { | ||
const unicodeSet = new MockUnicodeSet("[ħa-z]", [[0x41, 0x7A], [0x0127, 0x0127]]); | ||
assert.equal(unicodeSet.length, 2); | ||
}); | ||
it('can provide a correct string representation', () => { | ||
const unicodeSet = new MockUnicodeSet("[ħa-z]", [[0x41, 0x7A], [0x0127, 0x0127]]); | ||
assert.deepEqual(unicodeSet.toString(), "[ħa-z]"); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary as you have
public
in the constructor properties, which does the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now with improved knowledge of TS, I can take out the whole
MockUnicodeSet
.