test(common/web/types): unit tests for unicodeset-parser-api #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
common/
common/web/
test
markcsinclair
changed the base branch from
master
to
test/common/web/types/9052-unit-tests-string-list
Base automatically changed from
test/common/web/types/9052-unit-tests-string-list
to
master
November 28, 2024 01:49
…052-unit-tests-unicodeset-parser-api
mcdurdin
approved these changes
Nov 28, 2024
Comment on lines
16
to
17
| this.pattern = pattern; | ||
| this.ranges = ranges; |
There was a problem hiding this comment.
This shouldn't be necessary as you have public in the constructor properties, which does the same thing.
Suggested change
| this.pattern = pattern; | |
| this.ranges = ranges; |
There was a problem hiding this comment.
Now with improved knowledge of TS, I can take out the whole MockUnicodeSet.
…052-unit-tests-unicodeset-parser-api
markcsinclair
deleted the
test/common/web/types/9052-unit-tests-unicodeset-parser-api
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.148-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for
ldml-keyboard/unicodeset-parser-api.tsSee #9052
@keymanapp-test-bot skip