Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): trigger core ci checks on developer changes #11750

Closed
wants to merge 1 commit into from

Conversation

jahorton
Copy link
Contributor

I hope this is the right way to do things; the goal is to trigger Core CI checks whenever Developer changes are detected in order to prevent the scenario fixed by #11749 from going undetected again.

@keymanapp-test-bot skip

@jahorton jahorton requested a review from mcdurdin as a code owner June 10, 2024 08:51
@mcdurdin
Copy link
Member

I mean, this works, but it reflects an internal tangle of dependencies which it would be better to resolve if possible. After all, we shouldn't need developer to build core.

But it seems like we currently need developer in order to run core tests (which feels awkward). Two potentially better solutions:

  1. In theory, we could restructure the tests to be a separate build configuration that depends on both core+developer.
  2. We could use npx @keymanapp/kmc[@tier] to build keyboards used for Core tests.

But, we could accept this for now, and do this as future work (as I am not about to do it right now).

@mcdurdin
Copy link
Member

I will review this once I am back on deck. I don't think it is urgent.

@mcdurdin
Copy link
Member

OK, I have a clearer idea now of why I was feeling uncomfortable with this: this is testing some of the Developer cross-platform component build as a side-effect of building Core.

Instead, I would like to test the build of the cross-platform components of Developer as separate build configurations, rather than as a side-effect of testing Core. This will become more important as we move forward.

So I suggest we turn this into an issue to add 2 build configurations : Keyman Developer Test - Linux, Keyman Developer Test - mac, rather than adding Core test builds to the Developer triggers. This will then correspond with additional Release build configurations in the future to allow us to build distributions of Developer for those two platforms.

@jahorton
Copy link
Contributor Author

Closing this in favor of issue #11755 per @mcdurdin's input.

@jahorton jahorton closed this Jun 12, 2024
@mcdurdin mcdurdin deleted the chore/common/developer-triggers-core branch June 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants