Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): fix kmcmplib unit-test include paths #11749

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Jun 10, 2024

Backslashes in paths are Windows-only, may have caused recent *nix-agent-based CI-build failures.

@keymanapp-test-bot skip

Backslashes in paths are Windows-only, may have caused recent *nix CI-build failures.
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jun 10, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@jahorton
Copy link
Contributor Author

I'm manually triggering "Test: Keyman Core" builds here to validate the potential fix.

@jahorton jahorton changed the title fix(developer): fix include paths fix(developer): fix unit-test include paths Jun 10, 2024
@markcsinclair markcsinclair changed the title fix(developer): fix unit-test include paths fix(developer): fix kmcmplib unit-test include paths Jun 10, 2024
@markcsinclair
Copy link
Contributor

This will also need to be merged into PR #11378, which continues the kmcmplib unit tests.

@markcsinclair
Copy link
Contributor

markcsinclair commented Jun 10, 2024

@jahorton How do I add the Core/Common tests to my list of checks on PR #11378?

@markcsinclair
Copy link
Contributor

LGTM

@jahorton
Copy link
Contributor Author

jahorton commented Jun 10, 2024

@jahorton How do I add the Core/Common tests to my list of checks on PR #11378?

I believe the test triggers are managed in these two spots:

bc_test_android=(KeymanAndroid_TestPullRequests KeymanAndroid_TestSamplesAndTestProjects)
bc_test_ios=(Keyman_iOS_TestPullRequests Keyman_iOS_TestSamplesAndTestProjects)
bc_test_linux=(KeymanLinux_TestPullRequests Keyman_Linux_Test_Integration Keyman_Common_KPAPI_TestPullRequests_Linux deb-pr-packaging_GitHub)
bc_test_mac=(Keyman_KeymanMac_PullRequests Keyman_Common_KPAPI_TestPullRequests_macOS)
bc_test_windows=(KeymanDesktop_TestPullRequests KeymanDesktop_TestPrRenderOnScreenKeyboards Keyman_Common_KPAPI_TestPullRequests_Windows)
bc_test_web=(Keymanweb_TestPullRequests Keyman_Common_LMLayer_TestPullRequests Keyman_Common_KPAPI_TestPullRequests_WASM)
bc_test_developer=(Keyman_Developer_Test)

// Maps to trigger-definitions.inc.sh and must be kept in sync
export const testBuildConfigurations = {
'android': ['KeymanAndroid_TestPullRequests', 'KeymanAndroid_TestSamplesAndTestProjects'],
'ios': ['Keyman_iOS_TestPullRequests', 'Keyman_iOS_TestSamplesAndTestProjects'],
'linux': ['KeymanLinux_TestPullRequests', 'Keyman_Linux_Test_Integration', 'Keyman_Common_KPAPI_TestPullRequests_Linux', 'deb-pr-packaging_GitHub'],
'mac': ['Keyman_KeymanMac_PullRequests', 'Keyman_Common_KPAPI_TestPullRequests_macOS'],
'windows': ['KeymanDesktop_TestPullRequests', 'KeymanDesktop_TestPrRenderOnScreenKeyboards', 'Keyman_Common_KPAPI_TestPullRequests_Windows'],
'web': ['Keymanweb_TestPullRequests', 'Keyman_Common_LMLayer_TestPullRequests', 'Keyman_Common_KPAPI_TestPullRequests_WASM'],
'developer': ['Keyman_Developer_Test'],

Adding the Core tests under the 'developer' entries should do the trick, I believe. I'm not sure if it has to land on master first or if it's fine just being on the branch being tested, though.

@jahorton jahorton merged commit 03575d3 into master Jun 10, 2024
8 checks passed
@jahorton jahorton deleted the fix/developer/include-path-slashes branch June 10, 2024 08:41
@jahorton
Copy link
Contributor Author

I've gone ahead and put #11750 together; I also pinged our team lead to make sure I did it right.

@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.53-alpha

@mcdurdin
Copy link
Member

Backslashes in paths are Windows-only, may have caused recent *nix-agent-based CI-build failures.

Please link the failed builds for future reference. And include a relevant snippet of the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants