-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(developer): fix kmcmplib unit-test include paths #11749
Conversation
Backslashes in paths are Windows-only, may have caused recent *nix CI-build failures.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
I'm manually triggering "Test: Keyman Core" builds here to validate the potential fix. |
This will also need to be merged into PR #11378, which continues the kmcmplib unit tests. |
LGTM |
I believe the test triggers are managed in these two spots: keyman/resources/build/trigger-definitions.inc.sh Lines 47 to 53 in b8943ea
Adding the Core tests under the 'developer' entries should do the trick, I believe. I'm not sure if it has to land on |
I've gone ahead and put #11750 together; I also pinged our team lead to make sure I did it right. |
Changes in this pull request will be available for download in Keyman version 18.0.53-alpha |
Please link the failed builds for future reference. And include a relevant snippet of the log. |
Here's two of the failed builds that this addresses: |
Backslashes in paths are Windows-only, may have caused recent *nix-agent-based CI-build failures.
@keymanapp-test-bot skip