Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger 🍒 🏠 #11489

Conversation

mcdurdin
Copy link
Member

Cherry-pick of #11488.

The output from Keyman Core changed in #11172 to emit a KM_CORE_IT_INVALIDATE_CONTEXT action when a frame key is pressed, but the debugger was not catering for this scenario, causing an assertion failure.

Fixes: #11486
Fixes: KEYMAN-DEVELOPER-1Y4

@keymanapp-test-bot skip

The output from Keyman Core changed in #11172 to emit a
`KM_CORE_IT_INVALIDATE_CONTEXT` action when a frame key is pressed, but
the debugger was not catering for this scenario, causing an assertion
failure.

Fixes: #11486
Fixes: KEYMAN-DEVELOPER-1Y4
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner May 21, 2024 02:07
@mcdurdin mcdurdin added the cherry-pick Change already merged into another (stable) branch label May 21, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 21, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger 🍒 fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger 🍒 🏠 May 21, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S2 milestone May 21, 2024
@mcdurdin mcdurdin changed the title fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger 🍒 🏠 fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger 🍒 🏠 May 21, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit d3f41a5 into stable-17.0 May 23, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/cherry-pick/11486-handle-invalidate-context-in-debugger branch May 23, 2024 01:03
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Change already merged into another (stable) branch developer/ide/ developer/ fix stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants