fix(developer): handle KM_CORE_IT_INVALIDATE_CONTEXT in debugger
#11488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts
|
mcdurdin
changed the title
KM_CORE_IT_INVALIDATE_CONTEXT in debugger
darcywong00
reviewed
May 21, 2024
| @@ -360,6 +360,13 @@ function TDebugEventList.AddStateItems( | |||
|
|
|||
| AddDebugItem(debug, debugkeyboard, vk, modifier_state); | |||
|
|
|||
| if action._type = KM_CORE_IT_INVALIDATE_CONTEXT then | |||
| begin | |||
| // We always ignore invalidate context which can come when a frame key is | |||
There was a problem hiding this comment.
lgtm.
Is this the same behavior on a non-debug event?
There was a problem hiding this comment.
No, the debugger specifically ignores the invalidate context event because it always tracks the context, including markers. It's the only app that ever knows about markers, so it's the only app that can ignore the event.
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
deleted the
fix/developer/11486-handle-invalidate-context-in-debugger
branch
srl295
reviewed
May 22, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.41-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output from Keyman Core changed in #11172 to emit a
KM_CORE_IT_INVALIDATE_CONTEXTaction when a frame key is pressed, but the debugger was not catering for this scenario, causing an assertion failure.Fixes: #11486
Fixes: KEYMAN-DEVELOPER-1Y4
User Testing
TEST_DEBUGGER_KEYS: In the Keyman Developer debugger window, press a variety of keys, including letter keys, arrow keys, and more. The debugger should no longer crash.