-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): Update targetSdkVersion to 34 #10393
Conversation
User Test ResultsTest specification and instructions
Retesting Template
Test Artifacts |
Test Results
|
The app still ran fine. I'll re-open the OSK rotation issue, since that's separate from this change. |
Changes in this pull request will be available for download in Keyman version 17.0.248-alpha |
Typically, we just update the Android apps' targetSdkVersion at the beginning of the Alpha cycle.
I figure the minor update now will save us some Play Store hassle later this year.
Also
compileSdkVersion
got replaced withcompileSdk
Reference
https://developer.android.com/reference/tools/gradle-api/8.2/com/android/build/api/dsl/CommonExtension#compileSdkVersion(kotlin.String)
User Testing
Setup - Install the PR builds on an Android device/emulator