Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): Update targetSdkVersion to 34 #10393

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

darcywong00
Copy link
Contributor

Typically, we just update the Android apps' targetSdkVersion at the beginning of the Alpha cycle.
I figure the minor update now will save us some Play Store hassle later this year.

Also compileSdkVersion got replaced with compileSdk
Reference
https://developer.android.com/reference/tools/gradle-api/8.2/com/android/build/api/dsl/CommonExtension#compileSdkVersion(kotlin.String)

User Testing

Setup - Install the PR builds on an Android device/emulator

  • TEST_KEYMAN - Verifies Keyman for Android works
  1. Install Keyman for Android
  2. Verify Keyman app launches fine
  3. Verify the inapp keyboard works fine
  • TEST_FV - Verifies FirstVoices for Android works
  1. Install FirstVoices for Android
  2. Verify FV app launches fine
  3. Use the FV setup menus to install FV keyboard and enable as default system keyboard
  4. Launch Chrome and click text area
  5. Select FV keyboard
  6. Verify FV keyboard works fine

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 16, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 16, 2024

User Test Results

Test specification and instructions

  • 🟥 TEST_KEYMAN (FAILED): Tested with the attached PR build Keyman 17.0.245-alpha-test-10393 on Android 12.0 emulator (API 31) and here is my observation : 1. Changed the Keyman inapp in the Landscape orientation. 2. Typed some letters on the input text screen. 3. Longpressed the globe key to open the Keyboard picker menu. 4. Click the default keyboard. Here, I observed that the keyboard width had been reduced, and an empty black space had emerged at the bottom right corner of the Keyman app. Seems to be an issue (bug(android): Keyboard position does not fit properly in the screen after changing to Landscape Orientation in Android 12.0 OS #9191) (notes)
  • TEST_FV (PASSED): Tested with the attached PR build FirstVoices 17.0.245-alpha-test-10393 on Android 12.0 emulator (API 31) and here is my observation : 1. Installed FV keyboards and enabled FV as the default system keyboard. 2. Opened Chrome browser then clicked the text area. 3. Selected FV keyboard. Used FV keyboard in both Portrait and Landscape views and it seems to be working fine. (notes)
Retesting Template
@keymanapp-test-bot retest TEST_KEYMAN

Test Artifacts

@bharanidharanj
Copy link

Test Results

@bharanidharanj
Copy link

Test Results

  • TEST_FV (PASSED): Tested with the attached PR build FirstVoices 17.0.245-alpha-test-10393 on Android 12.0 emulator (API 31) and here is my observation : 1. Installed FV keyboards and enabled FV as the default system keyboard. 2. Opened Chrome browser then clicked the text area. 3. Selected FV keyboard. Used FV keyboard in both Portrait and Landscape views and it seems to be working fine.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 18, 2024
@darcywong00
Copy link
Contributor Author

Here, I observed that the keyboard width had been reduced, and an empty black space had emerged at the bottom right corner of the Keyman app. Seems to be an issue

The app still ran fine. I'll re-open the OSK rotation issue, since that's separate from this change.

@darcywong00 darcywong00 merged commit 4263d8e into master Jan 18, 2024
5 of 6 checks passed
@darcywong00 darcywong00 deleted the chore/android/target-sdk-34 branch January 18, 2024 23:35
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.248-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants