Skip to content

Commit

Permalink
Merge pull request #10393 from keymanapp/chore/android/target-sdk-34
Browse files Browse the repository at this point in the history
chore(android): Update targetSdkVersion to 34
  • Loading branch information
darcywong00 authored Jan 18, 2024
2 parents 2b03f8f + fdb14f2 commit 4263d8e
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 14 deletions.
4 changes: 2 additions & 2 deletions android/KMAPro/kMAPro/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ext.rootPath = '../../'
apply from: "$rootPath/version.gradle"

android {
compileSdkVersion 33
compileSdk 34
namespace="com.tavultesoft.kmapro"

// Don't compress kmp files so they can be copied via AssetManager
Expand All @@ -21,7 +21,7 @@ android {
defaultConfig {
applicationId "com.tavultesoft.kmapro"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34

//println "===DUMPING PROPERTIES==="
//dumpProperties(project) // Use this to dump all external properties for debugging TeamCity integration
Expand Down
4 changes: 2 additions & 2 deletions android/KMEA/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ ext.rootPath = '../../'
apply from: "$rootPath/version.gradle"

android {
compileSdkVersion 33
compileSdk 34
namespace "com.keyman.engine"

defaultConfig {
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34

// VERSION_CODE and VERSION_NAME from version.gradle but Gradle removes them for libraries
buildConfigField "String", "KEYMAN_ENGINE_VERSION_NAME", "\""+VERSION_NAME+"\""
Expand Down
4 changes: 2 additions & 2 deletions android/Samples/KMSample1/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ plugins {
}

android {
compileSdkVersion 33
compileSdk 34
namespace="com.keyman.kmsample1"

// Don't compress kmp files so they can be copied via AssetManager
Expand All @@ -14,7 +14,7 @@ android {
defaultConfig {
applicationId "com.keyman.kmsample1"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34
versionCode 1
versionName "1.0"
}
Expand Down
4 changes: 2 additions & 2 deletions android/Samples/KMSample2/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ plugins {
}

android {
compileSdkVersion 33
compileSdk 34
namespace="com.keyman.kmsample2"

// Don't compress kmp files so they can be copied via AssetManager
Expand All @@ -14,7 +14,7 @@ android {
defaultConfig {
applicationId "com.keyman.kmsample2"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34
versionCode 1
versionName "1.0"
}
Expand Down
4 changes: 2 additions & 2 deletions android/Tests/KeyboardHarness/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ext.rootPath = '../../../'
apply from: "$rootPath/version.gradle"

android {
compileSdkVersion 33
compileSdk 34
namespace="com.keyman.android.tests.keyboardHarness"

// Don't compress kmp files so they can be copied via AssetManager
Expand All @@ -21,7 +21,7 @@ android {
defaultConfig {
applicationId "com.keyman.android.tests.keyboardHarness"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34

// VERSION_CODE and VERSION_NAME from version.gradle
versionCode VERSION_CODE as Integer
Expand Down
3 changes: 1 addition & 2 deletions android/Tests/keycode/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ ext.rootPath = '../../../'
apply from: "$rootPath/version.gradle"

android {
compileSdkVersion 33
namespace="com.keyman.android.tests.keycode"

defaultConfig {
applicationId "com.keyman.android.tests.keycode"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34

// VERSION_CODE and VERSION_NAME from version.gradle
versionCode VERSION_CODE as Integer
Expand Down
4 changes: 2 additions & 2 deletions oem/firstvoices/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ ext.rootPath = '../../../../android'
apply from: "$rootPath/version.gradle"

android {
compileSdkVersion 33
compileSdk 34
namespace="com.firstvoices.keyboards"

defaultConfig {
applicationId "com.firstvoices.keyboards"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34

// VERSION_CODE and VERSION_NAME from version.gradle
versionCode VERSION_CODE as Integer
Expand Down

0 comments on commit 4263d8e

Please sign in to comment.