Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): unbreak some ts paths #10279

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(web): unbreak some ts paths #10279

merged 1 commit into from
Dec 19, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 18, 2023

@srl295 srl295 self-assigned this Dec 18, 2023
@srl295
Copy link
Member Author

srl295 commented Dec 18, 2023

ideally there'd be an eslint to catch this?

Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rc-swag rc-swag merged commit 50d5da7 into master Dec 19, 2023
20 checks passed
@rc-swag rc-swag deleted the fix/web/unbreak-epic-ldml branch December 19, 2023 01:12
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.233-alpha

@mcdurdin
Copy link
Member

ideally there'd be an eslint to catch this?

It feels like it should be caught at build time. It's kinda weird how it works in some build states but not others. Not sure how best to fix.

@mcdurdin
Copy link
Member

microsoft/vscode#137446 (comment) is relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants